Repository navigation
fix(voice): stop microphone capture during startup - #9696
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryMakes voice startup cancellable while the token request, microphone permission, or provider connection is pending.
No actionable issues were found. Review was based on source inspection; browser checks were not run.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Scoped Biome and
git diff --checkpassed. Pre-fix CI fails as intended: after cancellation, the audio track remains live and the connection stays pending. Fixed-head CI passed: full lint/type/audit, unit/integration, production builds, desktop/mobile, and hosted HTTP/browser acceptance. Packaged transport:32 passed; extension navigation:10; composer:16 plus1 optional live-provider skip; access:16. Browser errors:0. Both reviewers:5/5, zero open threads. Provider transport is simulated for deterministic cancellation coverage; this does not claim live-provider acceptance.Checklist
test-auditauthoring gate)