Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mwbrooks-tracer-start #826 +/- ##
=========================================================
- Coverage 80.56% 80.54% -0.03%
=========================================================
Files 246 246
Lines 18914 18899 -15
=========================================================
- Hits 15238 15222 -16
- Misses 3676 3677 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ooks-otel-api-app
…ooks-otel-api-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A - internal refactor with no user-facing changes.
Summary
This pull request moves the 15 spans in
internal/api/app.gofrom OpenTracing to the OpenTelemetry API, so maintainers are one file closer to removingopentracing-go.appandapp_idare strings, and the two prompt responses are booleansStacked on #825, which adds
tracer.Start.Testing
go test ./internal/api/Requirements