Skip to content

refactor(api): use OpenTelemetry spans in internal/api/app.go - #826

Open
mwbrooks wants to merge 3 commits into
mwbrooks-tracer-startfrom
mwbrooks-otel-api-app
Open

mwbrooks wants to merge 3 commits into
mwbrooks-tracer-startfrom
mwbrooks-otel-api-app

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal refactor with no user-facing changes.

Summary

This pull request moves the 15 spans in internal/api/app.go from OpenTracing to the OpenTelemetry API, so maintainers are one file closer to removing opentracing-go.

ctx, span := tracer.Start(ctx, "apiclient.UpdateApp")
span.SetAttributes(attribute.String("app", appID))
defer span.End()
  • Span names stay the same, so existing Honeycomb queries keep working
  • Tags keep their types: app and app_id are strings, and the two prompt responses are booleans

Stacked on #825, which adds tracer.Start.

Testing

  1. Run go test ./internal/api/

Requirements

@mwbrooks mwbrooks added this to the Next Release milestone Nov 20, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Nov 20, 2026
@mwbrooks mwbrooks self-assigned this Nov 20, 2026
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.54%. Comparing base (523cd46) to head (68a0220).

Files with missing lines Patch % Lines
internal/api/app.go 82.05% 7 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           mwbrooks-tracer-start     #826      +/-   ##
=========================================================
- Coverage                  80.56%   80.54%   -0.03%     
=========================================================
  Files                        246      246              
  Lines                      18914    18899      -15     
=========================================================
- Hits                       15238    15222      -16     
- Misses                      3676     3677       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks
mwbrooks marked this pull request as ready for review November 21, 2026 04:47
@mwbrooks
mwbrooks requested a review from a team as a code owner November 21, 2026 04:47
@mwbrooks
mwbrooks requested a review from zimeg November 21, 2026 04:47

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔭 @mwbrooks LGTM! Span names and tag types carry over one for one, and the nesting test from #825 keeps the postJSON spans parented under these. One file closer to dropping opentracing-go 🪓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants