Repository navigation
Treat null name arrays as empty JSONObject selections - #1097
Open
illusionoftalha wants to merge 1 commit into
Open
illusionoftalha wants to merge 1 commit into
illusionoftalha wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1096.
Both subset constructors dereference names.length in their constructor delegation, so a null names array fails before any fields can be selected. Treat null consistently with an empty names array: allocate an empty map and return without copying keys or reflecting over fields. Document that behaviour in both constructors.
Add regressions for null names with a populated JSONObject, null field names with a public-field object, and passing the null result of JSONObject.getNames on an empty object back to the subset constructor. The source JSONObject remains unchanged.
Validation on Windows / JDK 17: