Repository navigation
Package with the same Composer as new, and silence SKERNEL's scan report - #10
Merged
Merged
Conversation
Every command of a packaged SKERNEL opened with a warning that the annotation scan had skipped classes, such as optional Symfony bundles whose dependencies are not installed. Nothing in it is something a SKERNEL user can act on. StderrLogger now drops records whose event is an annotation scan's, and writes the rest as before. A project that SKERNEL builds still reports its own scan through its own logger. A test requires an empty STDERR from --version, and a real packaged SKERNEL wrote nothing to STDERR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
package looked only for a composer binary in PATH, while new also tries the user's usual locations and falls back to SKERNEL's own Composer. Now that both need Composer the same way, package asks ComposerLocator too, so a machine without Composer can package a project. --composer and the package.composer setting still choose a binary, and are used unchecked. The README and the schema describe the new default, and Composer is no longer listed as a requirement. The README also stops mentioning scan summaries on STDERR, which the previous commit removed. A real package with an empty environment and no Composer used SKERNEL's own, and the resulting binary served requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Composer for
packagepackagenow finds Composer the waynewdoes:--composeror thepackage.composersetting, used unchecked, or else the first working Composer 2 inPATHor the user's usual locations, or else SKERNEL's own.Scan report
StderrLoggernow drops records whose event is an annotation scan's, and writes the rest as before.Compatibility
packageno longer fails whencomposeris not inPATH. It uses a Composer from the user's usual locations or SKERNEL's own instead, which builds a managed PHP the first time.Validation
composer testpasses 121 tests andcomposer format:checkpasses. A test requires an empty STDERR from--version.--version./indexand/user, answered/missingwith a 404, and exited with status 0 on SIGTERM.Merge this before #11, which starts from this branch.
🤖 Generated with Claude Code