Repository navigation
🔧 build(lint): adopt simplint 0.7.1 - #316
Merged
Merged
Conversation
Ruff's undocumented-* rules ask for docstrings that simplint's function-docstring rule removes from internal code, so simplint refuses to run with them on. undocumented-public-api covers the public API instead, in reST.
Applied with simplint 0.7.1 --fix --unsafe-fixes, then the formatters via prek.
The classes move to _server.py and _index.py, so the package __init__ holds re-exports only. Imports from devpi_process stay the same.
Fields with no description name a parameter without saying what it is, and a :param: that repeats its name adds nothing. The one-line reprs and __enter__ become imperative sentences, since a :returns: field there reads as a non-imperative summary.
simplint's suppression-without-reason wants the why after each ignore and pragma, so a later reader can tell whether it still applies.
The fixture module is loaded by path, so its names are private constants; Final keeps them from being reassigned.
The inlined return kept parentheses around each division, and the autofix turned the _setup_client docstring into a comment that only restates the method.
gaborbernat
added
enhancement
gaborbernat
marked this pull request as ready for review
November 7, 2026 05:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds simplint 0.7.1 to pre-commit, so the conventions Ruff cannot check are enforced on every change rather than in review. 🧹 The public API is unchanged:
Index,IndexServerand__version__still import fromdevpi_process. Ruff'sundocumented-*rules give way to simplint'sundocumented-public-api, which asks for reST documentation only on what the package exports. Hooks run as Ruff lint, then simplint, then Ruff format, with explicit prek priorities so independent hooks run in parallel; pre-commit ignores the key.Commits
Each commit is one step, so the review can tell what simplint did on its own from what needed hand work:
simplint check --fix --unsafe-fixes, untouched;__init__keeps only re-exports, withIndexServerandIndexmoving to their own private modules; the documented fields get descriptions; every suppression gets a reason; test fixture names become constants;