Repository navigation
Skip the backslash-escape scan for text without a backslash - #762
Merged
Merged
Conversation
_encode_backslash_escapes() runs one replace() per _escape_table entry, and every link URL is in that table, so link-heavy documents are quadratic. Every search string starts with a backslash; return early when the text has none.
ptweezy
force-pushed
the
backslash-escape-guard
branch
from
November 4, 2026 03:44
d05e62f to
d6188a5
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_encode_backslash_escapes()runs onestr.replace()per_escape_tableentry, and_protect_url()adds every link URL to that table. Documents with many links are quadratic.Change
Every search string in the loop starts with a backslash. Return early when the text has none. Output is unchanged.
Timing
Median of 5 alternating rounds, a new
Markdown()per call, identical output.No links: 1.1x. A backslash in every paragraph: 1.0x.
MacBook Air M4, macOS 27.2, Python 3.14.10.
Tests
python test.py -- -knownfailure: 304 pass (master: 303); ReDoS 12 of 12.Related: #724 sped up the sibling
_unescape_special_chars()(#635).