Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nested-exists-false-event-filter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/core": patch
---

Fix `eventFilterMatches` returning `false` for nested `$exists: false` filters when the parent key is missing or `null`
6 changes: 1 addition & 5 deletions packages/core/src/eventFilterMatches.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@ import type { EventFilter } from "./schemas/eventFilter.js";
// An example would be [{ $endsWith: ".png" }, { $startsWith: "images/" } ]
export function eventFilterMatches(payload: any, filter: EventFilter): boolean {
if (payload === undefined || payload === null) {
if (Object.entries(filter).length === 0) {
return true;
} else {
return false;
}
payload = {};
}

for (const [patternKey, patternValue] of Object.entries(filter)) {
Expand Down
12 changes: 12 additions & 0 deletions packages/core/test/eventFilterMatches.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,18 @@ describe("eventFilterMatches", () => {
expect(eventFilterMatches(payload, filter)).toBe(true);
});

it("should return true for nested $exists = false when the parent key is missing or null", () => {
const filter: EventFilter = {
user: {
email: [{ $exists: false }],
},
};
expect(eventFilterMatches({}, filter)).toBe(true);
expect(eventFilterMatches({ user: null }, filter)).toBe(true);
expect(eventFilterMatches({ user: {} }, filter)).toBe(true);
expect(eventFilterMatches({ user: { email: "a@b.com" } }, filter)).toBe(false);
});

it("should return true when payload does match numeric condition", () => {
const payload = {
name: "John",
Expand Down