Skip to content

fix: Accessible interactive and editor filters - #2620

Draft
bprusinowski wants to merge 2 commits into
fix/a11y-metadata-panelfrom
fix/a11y-filters
Draft

bprusinowski wants to merge 2 commits into
fix/a11y-metadata-panelfrom
fix/a11y-filters

Conversation

@bprusinowski

Copy link
Copy Markdown
Member

Part of the GitLab a11y audit. Fixes issue 130 and the filter part of 133, plus the filter findings from the keyboard audit.

This PR:

  • opens multi-value filters with the keyboard, and translates the dropdown's Open, Close and No options texts
  • turns hierarchical filters into a button that opens a labelled, searchable tree dialog, which announces the number of matches
  • keeps focus on a filter while the chart reloads, by making it read-only instead of disabled
  • keeps focus after choosing a value, toggling a legend item, adding a filter or reordering one
  • gives drag handles, the "Interactive" switches and the shared-filter switches specific names

How to test

  1. In a chart with interactive filters, Tab to a filter and open it with ArrowDown. Pick a value and check that focus stays on the filter while the chart reloads.
  2. Open a hierarchical filter (for example in an NFI chart), search, pick a value by keyboard, and check that focus returns to the filter.
  3. In the editor, move a filter with Space and the arrow keys, and check that focus stays on its handle.
  4. Run npx playwright test e2e/data-filters-keyboard.spec.ts e2e/editor-filters-keyboard.spec.ts.

  • I added a CHANGELOG entry
  • I made a self-review of my own code
  • I wrote tests for the changes (if applicable)

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
visualization-tool Ready Ready Preview Nov 20, 2026 3:20pm UTC

Request Review

This branch was successfully deployed

1 active deployment
Preview — 8da2742c Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant