Repository navigation
fix(v0): backport Tao macOS lifecycle and shadow fixes - #93
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #92 to the original root-layout
v0package. This branch starts at latestorigin/v0(bf9e854); no merge or rebase from main, architecture changes, package version bumps or publication.Changes
73ab3e94986f045ad379faee9b2560bffd84012cand include the resolved root Cargo.lock. v0 previously ignored/untracked this file; it is explicitly added so the dependency resolution is reviewable and reproducible.node:test/node:assertsetup and load the actual rootindex.jspublic API and locally built N-API addon. No monorepo tools or workspace structure were copied.bun run test:native:macoscommand and a macOS native job in the existing validation workflow.Related: github/copilot-cli#5398 and #91. Neither issue is automatically closed.
Reproductions
The parent Node test process hosts HTTP independently of native child execution. Fresh Node/Bun child processes own AppKit on the main thread, with a 25-second watchdog, explicit native disposal/pump shutdown, process reaping and HTTP server cleanup.
Loading tests use
whenReady({interval:50,ref:false}), localhost, inline HTML and data URLs. Each DOM must load before another window is created or explicit focus is requested. They exercise JavaScript reads/mutation, timers, HTTP fetches, IPC, seven seconds without input, twenty manual pump iterations, multiple windows, resizing, focus and cleanup.Latest final loading results: Node roots=1, HTTP ticks=89, IPC=175, data JS ticks=68; Bun roots=1, HTTP ticks=88, IPC=173, data JS ticks=68. All three pages passed DOM mutation and lifecycle checks.
Shadow tests cover all 16 combinations of decorations/resizable/minimizable/shadow after webview attachment, style mutations, explicit disabling and runtime shadow changes. Rebuilding v0 with the original
9bb2bdcpin fails under both Node and Bun for the exact all-false-style/true-shadow configuration in #91; restoring the updated pin passes.Validation
Local host: macOS 27.0.1 (26A434), ARM64; Node 24.22.1, Bun 1.4.4, Rust 1.99.1.
Passed:
bun install --frozen-lockfile, releasebun run buildusing the real root addon.bun run test: 10 passed, including the native custom-protocol test and strict generated declaration/type fixture checks.bun run test:native:macos: 4 passed, covering Node and Bun loading/shadows.cargo check/cargo check --locked,cargo clippy -- -D warnings,cargo test --lib(17 passed).bun run lint(two existing unused-variable warnings in examples), full Prettier check,cargo fmt -- --check, new JS syntax checks andgit diff --check.Limits: