Repository navigation
feat(view3d): hints, layer play and view toolbar on the PuzlWerk main view (A2, A3) - #81
Conversation
|
Review: CLEAR head=a22f3be8633a6cd001177191382a0e5fdeb0ac8b patch-id=b67a3f4ed05f8d098212103b59cc2ec174065965 pr=81 |
The viewer draws no overlay texts. The wording and conditions of the help line, the wide-turn badge and the locked hint follow the existing view; the wide badge reads the viewer's play events. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A pure name for the viewer's turn events (selection or end), used as a state signal on the stage host so tests can wait on the turn instead of a timer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The viewer draws no texts. The main view (flag only) shows the help line, the wide-turn badge and the locked hint as DOM over the stage, with the wording and conditions of the existing view. The wide badge follows the viewer's play events; the locked hint follows a drag on the stage while the layers are locked (view mode). With layer moves on, the stage plays layers with the move policy any; the dialogs stay view only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The start-distance check used toHaveCount(0), which waits for the hint to expire and so passes after a wrongly early hint. A one-shot count after two frames fails on it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
FACES button list, face-letter and arrow-key shortcuts, toggle labels and the pitch/yaw reading of a display orientation, with the labels, steps and limits of the existing toolbar. A test ties the viewer's presets to the existing view's angles. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n view Behind the flag the main view gets the FACES presets, the Stickerless, Auto-rotate and Move layers toggles and the face-letter and arrow-key shortcuts of the existing toolbar, driving the stage through setViewPreset, setDisplayOrientation, setAppearance, setAutoRotate and the interaction mode. The lock switches play and view mode without rebuilding the shown state; the seam setting reaches the play target. The CUBE group, the move history and the sound toggle need app state and are not part of this change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
a22f3be to
5fea85e
Compare
Packages A2 (hints and layer play) and A3 (view toolbar and shortcuts) of the main-view migration, behind
?viewer=puzlwerk; the default view is unchanged. Replaces #79, which cannot be rebased without rewriting GitHub-made commits. Refs #29,docs/viewer-migration-inventory.md(G4 to G9).Changes
mainprop the stage plays layers (move policyany), view mode while locked.main6095607; tree equal to the old branch head 0b301e5 (b736cb82),git range-diffall=.Known nits (not blocking): see the reviews at #79 (comment) and #80 (comment); they go to a follow-up package.
Tests
main: 47 failed, 2051 passed; +16 new, the 47 are the LFS failures). typecheck, lint, format:check, typos,git diff --check: 0 findings.main-view-bars,main-view-hints,main-view-flag,viewer-spike: 27 pass;cubeView3D-view: 11 pass.mainto head):index394.93 to 392.04 kB,cubeView3D48.43 to 47.47,puzlwerkCubeView770.24 to 783.91 (flag only); default-path shared chunkscubeView3DState+Stdlib_Int(3.94 kB) becomeuseCubeHelpHint+CubeSizeRange.res+Primitive_object(8.32 kB), preloaded withcubeView3D.Stack: none, restacks 0, heavy runs 0.
Not verified: real GPU; look acceptance by the owner.
Blocker: none.
No session links.
🤖 Generated with Claude Code