Skip to content

feat(view3d): hints, layer play and view toolbar on the PuzlWerk main view (A2, A3) - #81

Merged
wstein merged 6 commits into
mainfrom
feat/main-view-a2-hints-2
Nov 19, 2026
Merged

wstein merged 6 commits into
mainfrom
feat/main-view-a2-hints-2

Conversation

@wstein

@wstein wstein commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Packages A2 (hints and layer play) and A3 (view toolbar and shortcuts) of the main-view migration, behind ?viewer=puzlwerk; the default view is unchanged. Replaces #79, which cannot be rebased without rewriting GitHub-made commits. Refs #29, docs/viewer-migration-inventory.md (G4 to G9).

Changes

Known nits (not blocking): see the reviews at #79 (comment) and #80 (comment); they go to a follow-up package.

Tests

  • Full vitest: 47 failed, 2067 passed (main: 47 failed, 2051 passed; +16 new, the 47 are the LFS failures). typecheck, lint, format:check, typos, git diff --check: 0 findings.
  • e2e: main-view-bars, main-view-hints, main-view-flag, viewer-spike: 27 pass; cubeView3D-view: 11 pass.
  • Bundle (main to head): index 394.93 to 392.04 kB, cubeView3D 48.43 to 47.47, puzlwerkCubeView 770.24 to 783.91 (flag only); default-path shared chunks cubeView3DState + Stdlib_Int (3.94 kB) become useCubeHelpHint + CubeSizeRange.res + Primitive_object (8.32 kB), preloaded with cubeView3D.
  • CI at head: success at a22f3be (test 12m5s, typos 6s; run 44494429094)
    Stack: none, restacks 0, heavy runs 0.

Not verified: real GPU; look acceptance by the owner.

Blocker: none.

No session links.

🤖 Generated with Claude Code

@wstein

wstein commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=a22f3be8633a6cd001177191382a0e5fdeb0ac8b patch-id=b67a3f4ed05f8d098212103b59cc2ec174065965 pr=81
Restack review, no new code. Trees of a22f3be, 0b301e5 and 4e61ef5 are all b736cb82; old A1 base ed0412b and main 6095607 share tree 98f9708e.
git range-diff 959e0e24~1..0b301e58 origin/main..a22f3be: 6 of 6 =, same order; no merge commits; author and committer Werner Stein (noreply), Co-Authored-By in 6 of 6, no session links.
git diff --stat of main...a22f3be equals ed0412b6...0b301e58 (12 files, +1265/-13); no A1 file (e.g. puzlwerkMainView.ts) in the diff.
The CLEAR reviews of #79 (b8cd215) and #80 (4e61ef5) therefore apply to this content; their nits stay non-blocking.
Checks at head (copy via git archive, Node 22.23.4): rescript:build, typecheck, lint, format:check, typos, git diff --check: exit 0.
Vitest puzlwerkMainView, cubeView3DChoice, puzlwerkHints, puzlwerkBars: 21 passed; the two new files hold 9 + 7 = 16 tests, matching 2067 - 2051.
CI run 44494429094 (pull_request, attempt 1): test and typos success; pages and release do not trigger on pull_request.
Not run (load above 10): full vitest, build and chunk sizes, e2e; the earlier figure of 2076 passed stays unexplained.

@wstein
wstein marked this pull request as ready for review November 19, 2026 09:30
wstein and others added 6 commits November 19, 2026 10:31
The viewer draws no overlay texts. The wording and conditions of the help
line, the wide-turn badge and the locked hint follow the existing view;
the wide badge reads the viewer's play events.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A pure name for the viewer's turn events (selection or end), used as a
state signal on the stage host so tests can wait on the turn instead of
a timer.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The viewer draws no texts. The main view (flag only) shows the help line,
the wide-turn badge and the locked hint as DOM over the stage, with the
wording and conditions of the existing view. The wide badge follows the
viewer's play events; the locked hint follows a drag on the stage while
the layers are locked (view mode). With layer moves on, the stage plays
layers with the move policy any; the dialogs stay view only.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The start-distance check used toHaveCount(0), which waits for the hint to
expire and so passes after a wrongly early hint. A one-shot count after
two frames fails on it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
FACES button list, face-letter and arrow-key shortcuts, toggle labels
and the pitch/yaw reading of a display orientation, with the labels,
steps and limits of the existing toolbar. A test ties the viewer's
presets to the existing view's angles.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n view

Behind the flag the main view gets the FACES presets, the Stickerless,
Auto-rotate and Move layers toggles and the face-letter and arrow-key
shortcuts of the existing toolbar, driving the stage through
setViewPreset, setDisplayOrientation, setAppearance, setAutoRotate and
the interaction mode. The lock switches play and view mode without
rebuilding the shown state; the seam setting reaches the play target. The
CUBE group, the move history and the sound toggle need app state and are
not part of this change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein
wstein force-pushed the feat/main-view-a2-hints-2 branch from a22f3be to 5fea85e Compare November 19, 2026 09:34
@wstein
wstein merged commit 2a84c77 into main Nov 19, 2026
2 checks passed
@wstein
wstein deleted the feat/main-view-a2-hints-2 branch November 19, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant