Skip to content

chore(vendor): re-vendor the puzlwerk viewer archive to a3dfe2f0 - #87

Merged
wstein merged 1 commit into
mainfrom
chore/revendor-viewer-mitre
Nov 19, 2026
Merged

wstein merged 1 commit into
mainfrom
chore/revendor-viewer-mitre

Conversation

@wstein

@wstein wstein commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Re-vendors the @puzlwerk/viewer tarball to wstein/puzlwerk main a3dfe2f0449254aaf1b9a653cee9d2c5670ba577 (contains wstein/puzlwerk#101: miter cut faces in the CubeState bridge presentation). Vendor update only; no main-view change, no code that uses new API.

Changes:

  • vendor/puzlwerk-viewer-0.1.0-a3dfe2f0.tgz replaces the 3979efb5 archive.
  • package.json, package-lock.json (resolved + integrity sha512) point at the new archive; dependencies unchanged.
  • vendor/viewer.json and vendor/README.md pin artifact, SHA-256 and source revision.

Provenance: git archive of the source commit, npm ci, npm run build, npm pack --workspace @puzlwerk/viewer run twice (Node 24.22.2); both runs SHA-256 035433edee53bef891a8f6f6907007981604165ff433903cfeace2f5c4eedacf, 113 files, 172985 bytes, dist/bridge/core 11 files. Differs from the 3979efb5 archive in README.md and dist/bridge/{cube-state.mjs,index.mjs,index.d.mts}; NOTICE and license files unchanged. dist/bridge/cube-state.mjs now sets miterCutFaces: true. Old archive SHA-256 6a18433a506e996c24206fc98da7778259129d71922e527a66f779635d7ac5cb.

Tests: npm ci, typecheck (includes verify:viewer-vendor), lint, format:check, typos, build, git diff --check: exit 0. vitest: 2067 passed, 47 failed (LFS capture fixtures; same count as main). e2e (scratch Playwright config, SwiftShader) viewer-spike + main-view-*: 27 passed.
Main view, 3x3 stickerless, ?viewer=puzlwerk, base vs branch: red/orange pixels in the cube region 2398 vs 5; the red and blue lines between same-color stickers are gone.
Build time of the main view (click "3D View" to first frame with all draw calls, SwiftShader, load 9-11, 2 runs): 15x15 base 1893/1510 ms, branch 1895/1726 ms; 3x3 base 601/518 ms, branch 1093/1250 ms. Long-task total 15x15: base 1328/1220 ms, branch 1612/1441 ms.

Not verified: real GPU, the owner's judgment of the look; timings are from a software renderer on a loaded host.

Refs wstein/puzlwerk#100
Refs wstein/puzlwerk#101
Refs wstein/puzlwerk#102

Blocker: none.

No session links.

🤖 Generated with Claude Code

Re-vendors @puzlwerk/viewer to wstein/puzlwerk main a3dfe2f0449254aaf1b9a653cee9d2c5670ba577
(wstein/puzlwerk#101: miter cut faces in the CubeState bridge presentation).
Vendor update only; no code that uses new API.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=064fc71986f0e34504c20ed29b14776bad454e6c patch-id=7dc9d2f8d857e2034bf949aa50c79b6f4ee219a8 pr=87
Round 1. CI at head: typos and test success (run 44542216082). main moved to 17f292b (13 commits, no shared files); probe merge clean, same patch-id.
Archive reproduced from a git archive of puzlwerk a3dfe2f0 (Node 24.22.2, npm ci, build, pack x2): SHA-256 035433ed... both runs, byte-identical to the PR archive.
Content vs the 3979efb5 archive: same 113 paths, only README.md and dist/bridge/{cube-state.mjs,index.mjs,index.d.mts} differ; no install scripts, no .npmrc; NOTICE and license files unchanged.
Lock: only resolved and integrity changed; sha512 matches openssl. viewer.json and vendor/README.md pin artifact, SHA-256 and a3dfe2f0.
Head and probe merge: typecheck (incl. verify:viewer-vendor), lint, format:check, typos, build, git diff --check exit 0; vitest 2067/47 (head), 2169/47 (merge), failures are LFS photo pointers only.
e2e viewer-spike + main-view-*: head 27 passed, probe merge 43 passed. 5 pin mutations all fail verify:viewer-vendor.
Pixels, solved cube with yellow/blue/green shown, stickerless: red/orange 1155/1221/1463 -> 6/4/9 (3x3/5x5/7x7); colored seam lines gone. Stickered: identical pixel counts.
1 low nit src: viewer physical-scene.ts:139,506 and scene.ts:144,183 (puzlwerk a3dfe2f0). Main view build, SwiftShader, load 3-4, merge vs main:
long-task sum median 3x3 156->527 ms, 5x5 139->546 ms, 15x15 520->958 ms; first full frame +0.1-0.4 s, not reproducibly above 0.5 s.
Cause: 24 miter textures (64 px, 4x4 samples) per scene, cache per scene; first open builds two scenes (projection, then construction).
Fix path: module-level cache per pattern key, faster painter or 32 px; tracked in wstein/puzlwerk#102.
2 low nit PR text: old SHA-256 6a18433a... not named; 3x3 long-task increase not named.
Not checked: real GPU, scrambled-state repaint cost, owner look. No session links.

@wstein
wstein marked this pull request as ready for review November 19, 2026 15:00
@wstein
wstein merged commit 06fcec7 into main Nov 19, 2026
2 checks passed
@wstein
wstein deleted the chore/revendor-viewer-mitre branch November 19, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant