Skip to content

Add migrations 3.6 to 3.10, with three files that fail on purpose - #12

Merged
zchpeter merged 1 commit into
mainfrom
test/release-plan-3.6-3.10-failures
Nov 3, 2026
Merged

zchpeter merged 1 commit into
mainfrom
test/release-plan-3.6-3.10-failures

Conversation

@zchpeter

@zchpeter zchpeter commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Adds Bytebase's metadata migrations 3.6 to 3.10 (59 files) as the next revisions after base to 3.5.

Three files fail when applied, so the release plan page shows a failed task with the failure at the top, middle and end of the file list:

File Position Error
3.6/3.6.0001_move_environment_to_setting.sql 2 of 59 NULL into setting.value (not-null violation)
3.7/3.7.0023_smtp_clean.sql 30 of 59 division by zero
3.10/3.10.0007_remove_exporter_role.sql 58 of 59 guard block raises an exception

The rollout stops at the first failure. Later PRs fix the files one at a time, in that order.

🤖 Generated with Claude Code

59 new files. Three of them fail when applied, to show the plan page's
failed state at the top, middle and end of the file list:

- 3.6.0001 (file 2 of 59) inserts NULL into setting.value (NOT NULL).
- 3.7.0023 (file 30 of 59) divides by zero in its DELETE.
- 3.10.0007 (file 58 of 59) raises an exception from a guard block.

Later PRs fix them one at a time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

SQL Review Summary

  • Total Affected Rows: 17760
  • Overall Risk Level: 🔴 High
  • Advices Statistics: 0 Error(s), 4 Warning(s)

Detailed Results

File Target Affected Rows Risk Level Advices
migrations/3.6/3.6.0000_deprecate_anomaly.sql instances/bbmeta/databases/bb-gitops-migration 0 🔴 High -
migrations/3.6/3.6.0001_move_environment_to_setting.sql instances/bbmeta/databases/bb-gitops-migration 2 🔴 High -
migrations/3.6/3.6.0002_remove_environment_perms.sql instances/bbmeta/databases/bb-gitops-migration 410 🟡 Moderate -
migrations/3.6/3.6.0003_idp_deleted.sql instances/bbmeta/databases/bb-gitops-migration 210 🟡 Moderate -
migrations/3.6/3.6.0004_deprecate_approval_node_group_value.sql instances/bbmeta/databases/bb-gitops-migration 280 🟡 Moderate -
migrations/3.6/3.6.0005_backfill_task_version.sql instances/bbmeta/databases/bb-gitops-migration 5 🟡 Moderate -
migrations/3.7/3.7.0000_taskrun_rollout_at.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.7/3.7.0001_approval_template_creator.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.7/3.7.0002_risk_role.sql instances/bbmeta/databases/bb-gitops-migration 6 🟡 Moderate -
migrations/3.7/3.7.0003_approval_setting_cleanup.sql instances/bbmeta/databases/bb-gitops-migration 14 🟡 Moderate -
migrations/3.7/3.7.0004_remove_task_earliest_allowed_at.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.7/3.7.0005_remove_issue_comment_earliest_allowed_at.sql instances/bbmeta/databases/bb-gitops-migration 9 🟡 Moderate -
migrations/3.7/3.7.0006_backfill_database_metadata_version.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.7/3.7.0007_backfill_task_sheet_id.sql instances/bbmeta/databases/bb-gitops-migration 490 🟡 Moderate -
migrations/3.7/3.7.0008_flatten_plan_specs.sql instances/bbmeta/databases/bb-gitops-migration 4 🟡 Moderate -
migrations/3.7/3.7.0009_migrate_webhook_activity_to_event_type.sql instances/bbmeta/databases/bb-gitops-migration 16 🟡 Moderate -
migrations/3.7/3.7.0010_rename_activity_list_to_event_list.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.7/3.7.0011_migrate_plan_target_to_targets.sql instances/bbmeta/databases/bb-gitops-migration 2 🟡 Moderate -
migrations/3.7/3.7.0012_merge_changeDatabaseConfig_specs.sql instances/bbmeta/databases/bb-gitops-migration 100 🟡 Moderate -
migrations/3.7/3.7.0013_migrate_plan_export_target.sql instances/bbmeta/databases/bb-gitops-migration 2 🟡 Moderate -
migrations/3.7/3.7.0014_remove_branch_permissions.sql instances/bbmeta/databases/bb-gitops-migration 410 🟡 Moderate -
migrations/3.7/3.7.0015_backfill_issue_type.sql instances/bbmeta/databases/bb-gitops-migration 280 🟡 Moderate -
migrations/3.7/3.7.0016_migrate_enable_prior_backup.sql instances/bbmeta/databases/bb-gitops-migration 1040 🟡 Moderate -
migrations/3.7/3.7.0017_backfill_task_type.sql instances/bbmeta/databases/bb-gitops-migration 460 🟡 Moderate -
migrations/3.7/3.7.0018_migrate_policy_type.sql instances/bbmeta/databases/bb-gitops-migration 4 🟡 Moderate -
migrations/3.7/3.7.0019_migrate_setting_name.sql instances/bbmeta/databases/bb-gitops-migration 850 🟡 Moderate -
migrations/3.7/3.7.0020_add_and_migrate_task_environment_change_stage_uid_to_envid_remove_stage.sql instances/bbmeta/databases/bb-gitops-migration 0 🔴 High 1 Warning(s)
migrations/3.7/3.7.0021_delete_old_setting_policy.sql instances/bbmeta/databases/bb-gitops-migration 2 🟡 Moderate -
migrations/3.7/3.7.0022_policy_resource_type_check_drop.sql instances/bbmeta/databases/bb-gitops-migration 2 🟡 Moderate -
migrations/3.7/3.7.0023_smtp_clean.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate 1 Warning(s)
migrations/3.7/3.7.0024_ldap_security_protocol_enum.sql instances/bbmeta/databases/bb-gitops-migration 2 🟡 Moderate -
migrations/3.7/3.7.0025_remove_outbound_ip_list.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.7/3.7.0026_remove_plugin_agent_setting.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.7/3.7.0027_rename_client_secret_credential.sql instances/bbmeta/databases/bb-gitops-migration 630 🟡 Moderate -
migrations/3.8/3.8.0000_db_schema_add_todo.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.8/3.8.0001_drop_issue_subscriber_table.sql instances/bbmeta/databases/bb-gitops-migration 0 🔴 High -
migrations/3.8/3.8.0002_migrate_sql_setting.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.8/3.8.0003_change_table_ownership_to_current_user.sql instances/bbmeta/databases/bb-gitops-migration 0 🟢 Low -
migrations/3.8/3.8.0004_remove_plans_preview_permission.sql instances/bbmeta/databases/bb-gitops-migration 410 🟡 Moderate -
migrations/3.9/3.9.0000_plan_deleted.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.9/3.9.0001_remove_database_secret_permissions.sql instances/bbmeta/databases/bb-gitops-migration 410 🟡 Moderate -
migrations/3.9/3.9.0002_remove_unused_permissions.sql instances/bbmeta/databases/bb-gitops-migration 410 🟡 Moderate -
migrations/3.9/3.9.0003_remove_database_metadata_secrets.sql instances/bbmeta/databases/bb-gitops-migration 4 🟡 Moderate -
migrations/3.9/3.9.0004_issue_rollout_title.sql instances/bbmeta/databases/bb-gitops-migration 483 🟡 Moderate -
migrations/3.9/3.9.0005_drop_pipeline_name.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.9/3.9.0006_release_digest.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.9/3.9.0007_revision_type_backfill.sql instances/bbmeta/databases/bb-gitops-migration 440 🟡 Moderate -
migrations/3.9/3.9.0008_revision_index.sql instances/bbmeta/databases/bb-gitops-migration 0 🟡 Moderate -
migrations/3.9/3.9.0009_cleanup_deprecated_engines.sql instances/bbmeta/databases/bb-gitops-migration 332 🟡 Moderate -
migrations/3.9/3.9.0010_enable_metric_collection_backfill.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.10/3.10.0000_migrate_instance_metadata.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.10/3.10.0001_migrate_setting_policy.sql instances/bbmeta/databases/bb-gitops-migration 3 🟡 Moderate -
migrations/3.10/3.10.0002_drop_data_source_table.sql instances/bbmeta/databases/bb-gitops-migration 0 🔴 High -
migrations/3.10/3.10.0003_remove_deprecated_vcs_permissions.sql instances/bbmeta/databases/bb-gitops-migration 410 🟡 Moderate -
migrations/3.10/3.10.0004_migrate_disable_copy_data_policy.sql instances/bbmeta/databases/bb-gitops-migration 3 🟡 Moderate -
migrations/3.10/3.10.0005_migrate_restrict_issue_creation_for_sql_review_policy.sql instances/bbmeta/databases/bb-gitops-migration 250 🟡 Moderate -
migrations/3.10/3.10.0006_migrate_enforce_sql_review_to_project.sql instances/bbmeta/databases/bb-gitops-migration 3 🟡 Moderate -
migrations/3.10/3.10.0007_remove_exporter_role.sql instances/bbmeta/databases/bb-gitops-migration 1 🟡 Moderate -
migrations/3.10/3.10.0008_remove_exporter_permission.sql instances/bbmeta/databases/bb-gitops-migration 4 🟡 Moderate -
migrations/3.1/3.1.0001_backfill_postgres_database_tenant_mode.sql instances/bbmeta/databases/bb-gitops-migration-test 500 🟡 Moderate -
migrations/3.2/3.2.0005_remove_task_version.sql instances/bbmeta/databases/bb-gitops-migration-test 460 🟡 Moderate -
migrations/3.6/3.6.0000_deprecate_anomaly.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🔴 High -
migrations/3.6/3.6.0001_move_environment_to_setting.sql instances/bbmeta/databases/bb-gitops-migration-test 2 🔴 High -
migrations/3.6/3.6.0002_remove_environment_perms.sql instances/bbmeta/databases/bb-gitops-migration-test 410 🟡 Moderate -
migrations/3.6/3.6.0003_idp_deleted.sql instances/bbmeta/databases/bb-gitops-migration-test 210 🟡 Moderate -
migrations/3.6/3.6.0004_deprecate_approval_node_group_value.sql instances/bbmeta/databases/bb-gitops-migration-test 280 🟡 Moderate -
migrations/3.6/3.6.0005_backfill_task_version.sql instances/bbmeta/databases/bb-gitops-migration-test 5 🟡 Moderate -
migrations/3.7/3.7.0000_taskrun_rollout_at.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.7/3.7.0001_approval_template_creator.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.7/3.7.0002_risk_role.sql instances/bbmeta/databases/bb-gitops-migration-test 6 🟡 Moderate -
migrations/3.7/3.7.0003_approval_setting_cleanup.sql instances/bbmeta/databases/bb-gitops-migration-test 14 🟡 Moderate -
migrations/3.7/3.7.0004_remove_task_earliest_allowed_at.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.7/3.7.0005_remove_issue_comment_earliest_allowed_at.sql instances/bbmeta/databases/bb-gitops-migration-test 9 🟡 Moderate -
migrations/3.7/3.7.0006_backfill_database_metadata_version.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.7/3.7.0007_backfill_task_sheet_id.sql instances/bbmeta/databases/bb-gitops-migration-test 490 🟡 Moderate -
migrations/3.7/3.7.0008_flatten_plan_specs.sql instances/bbmeta/databases/bb-gitops-migration-test 4 🟡 Moderate -
migrations/3.7/3.7.0009_migrate_webhook_activity_to_event_type.sql instances/bbmeta/databases/bb-gitops-migration-test 16 🟡 Moderate -
migrations/3.7/3.7.0010_rename_activity_list_to_event_list.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.7/3.7.0011_migrate_plan_target_to_targets.sql instances/bbmeta/databases/bb-gitops-migration-test 2 🟡 Moderate -
migrations/3.7/3.7.0012_merge_changeDatabaseConfig_specs.sql instances/bbmeta/databases/bb-gitops-migration-test 100 🟡 Moderate -
migrations/3.7/3.7.0013_migrate_plan_export_target.sql instances/bbmeta/databases/bb-gitops-migration-test 2 🟡 Moderate -
migrations/3.7/3.7.0014_remove_branch_permissions.sql instances/bbmeta/databases/bb-gitops-migration-test 410 🟡 Moderate -
migrations/3.7/3.7.0015_backfill_issue_type.sql instances/bbmeta/databases/bb-gitops-migration-test 280 🟡 Moderate -
migrations/3.7/3.7.0016_migrate_enable_prior_backup.sql instances/bbmeta/databases/bb-gitops-migration-test 1040 🟡 Moderate -
migrations/3.7/3.7.0017_backfill_task_type.sql instances/bbmeta/databases/bb-gitops-migration-test 460 🟡 Moderate -
migrations/3.7/3.7.0018_migrate_policy_type.sql instances/bbmeta/databases/bb-gitops-migration-test 4 🟡 Moderate -
migrations/3.7/3.7.0019_migrate_setting_name.sql instances/bbmeta/databases/bb-gitops-migration-test 850 🟡 Moderate -
migrations/3.7/3.7.0020_add_and_migrate_task_environment_change_stage_uid_to_envid_remove_stage.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🔴 High 1 Warning(s)
migrations/3.7/3.7.0021_delete_old_setting_policy.sql instances/bbmeta/databases/bb-gitops-migration-test 2 🟡 Moderate -
migrations/3.7/3.7.0022_policy_resource_type_check_drop.sql instances/bbmeta/databases/bb-gitops-migration-test 2 🟡 Moderate -
migrations/3.7/3.7.0023_smtp_clean.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate 1 Warning(s)
migrations/3.7/3.7.0024_ldap_security_protocol_enum.sql instances/bbmeta/databases/bb-gitops-migration-test 2 🟡 Moderate -
migrations/3.7/3.7.0025_remove_outbound_ip_list.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.7/3.7.0026_remove_plugin_agent_setting.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.7/3.7.0027_rename_client_secret_credential.sql instances/bbmeta/databases/bb-gitops-migration-test 630 🟡 Moderate -
migrations/3.8/3.8.0000_db_schema_add_todo.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.8/3.8.0001_drop_issue_subscriber_table.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🔴 High -
migrations/3.8/3.8.0002_migrate_sql_setting.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.8/3.8.0003_change_table_ownership_to_current_user.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟢 Low -
migrations/3.8/3.8.0004_remove_plans_preview_permission.sql instances/bbmeta/databases/bb-gitops-migration-test 410 🟡 Moderate -
migrations/3.9/3.9.0000_plan_deleted.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.9/3.9.0001_remove_database_secret_permissions.sql instances/bbmeta/databases/bb-gitops-migration-test 410 🟡 Moderate -
migrations/3.9/3.9.0002_remove_unused_permissions.sql instances/bbmeta/databases/bb-gitops-migration-test 410 🟡 Moderate -
migrations/3.9/3.9.0003_remove_database_metadata_secrets.sql instances/bbmeta/databases/bb-gitops-migration-test 4 🟡 Moderate -
migrations/3.9/3.9.0004_issue_rollout_title.sql instances/bbmeta/databases/bb-gitops-migration-test 483 🟡 Moderate -
migrations/3.9/3.9.0005_drop_pipeline_name.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.9/3.9.0006_release_digest.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.9/3.9.0007_revision_type_backfill.sql instances/bbmeta/databases/bb-gitops-migration-test 440 🟡 Moderate -
migrations/3.9/3.9.0008_revision_index.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🟡 Moderate -
migrations/3.9/3.9.0009_cleanup_deprecated_engines.sql instances/bbmeta/databases/bb-gitops-migration-test 332 🟡 Moderate -
migrations/3.9/3.9.0010_enable_metric_collection_backfill.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.10/3.10.0000_migrate_instance_metadata.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.10/3.10.0001_migrate_setting_policy.sql instances/bbmeta/databases/bb-gitops-migration-test 3 🟡 Moderate -
migrations/3.10/3.10.0002_drop_data_source_table.sql instances/bbmeta/databases/bb-gitops-migration-test 0 🔴 High -
migrations/3.10/3.10.0003_remove_deprecated_vcs_permissions.sql instances/bbmeta/databases/bb-gitops-migration-test 410 🟡 Moderate -
migrations/3.10/3.10.0004_migrate_disable_copy_data_policy.sql instances/bbmeta/databases/bb-gitops-migration-test 3 🟡 Moderate -
migrations/3.10/3.10.0005_migrate_restrict_issue_creation_for_sql_review_policy.sql instances/bbmeta/databases/bb-gitops-migration-test 250 🟡 Moderate -
migrations/3.10/3.10.0006_migrate_enforce_sql_review_to_project.sql instances/bbmeta/databases/bb-gitops-migration-test 3 🟡 Moderate -
migrations/3.10/3.10.0007_remove_exporter_role.sql instances/bbmeta/databases/bb-gitops-migration-test 1 🟡 Moderate -
migrations/3.10/3.10.0008_remove_exporter_permission.sql instances/bbmeta/databases/bb-gitops-migration-test 4 🟡 Moderate -

@zchpeter
zchpeter merged commit a066691 into main Nov 3, 2026
1 check passed
zchpeter added a commit that referenced this pull request Nov 3, 2026
Removes the first of the three failures #12 injected, so
`3.6.0001_move_environment_to_setting.sql` matches Bytebase's original
migration again.

Expected rollout on test: 3.6.0000 joins the files already applied (the
#12 run applied it before failing); 3.6.0001 through 3.7.0022 apply; the
run fails at `3.7/3.7.0023_smtp_clean.sql` (file 30 of 59, division by
zero). The other two failures are fixed in later PRs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant