Skip to content

Agent: Draw a turn's steps as a thread - #1588

Open
matthewrball wants to merge 12 commits into
ux/turn-timerfrom
ux/turn-steps
Open

matthewrball wants to merge 12 commits into
ux/turn-timerfrom
ux/turn-steps

Conversation

@matthewrball

@matthewrball matthewrball commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does

  • Shows tool and thinking steps as compact rows on a rail instead of full-width cards.
  • Groups the steps between assistant messages under independent inline disclosures. Opening one group leaves the others alone; the explanations stay visible.
  • Each group shows its step count, tool-kind icons, and running, failed or stopped state. The turn's line is informational, with one clock for the whole turn.
  • Each step keeps its icon, title, command/path/query and edit counts. Opening a step shows the same arguments, output and diff as before. Folding its group keeps that choice.
  • Keeps the turn line's text shine and pulsing mark from Agent: Fold a turn's steps under one line that times the work #1587, label morphing, row entrance, disclosure fade, spring chevrons and reduced-motion behavior.

Preview

Native macOS app, using isolated offline fixture rows. These show the implemented view, not the browser prototype.

All groups folded:

Inline activity groups collapsed, with assistant explanations visible

Only the middle group open:

Only the middle activity group expanded; the others remain folded

Running and failed states (synthetic native fixtures) Only the active group says running; one turn-wide clock remains A folded group retains its failed label and the error notice stays visible

Notes

  • Part 2 of 4, stacked on Agent: Fold a turn's steps under one line that times the work #1587. Next: permission details (Agent: Show on a step that it waits for permission, and what you said #1589), files changed (Agent: List the files a turn changed under its reply #1590). This update does not restack those PRs.
  • Group counts, icons and states are cached when rows change, not regrouped per frame. Empty streamed messages and hidden plans do not split groups; completed thinking does not leave an old group marked running.
  • The existing tool-detail preference, individual tool disclosures, application Vim navigation and live-to-history rekeying are preserved. The prototype and temporary native fixture source are not included.
  • Checked on macOS with Rust 1.98: just ci-lint passed, including all feature sets and dependency checks. The app suite had 1,503 passes and 3 ignored tests; two previous turn-wide disclosure/layout expectations were updated for the new chunk headers, then all 20 transcript motion tests passed. App clippy --all-targets -- -D warnings also passed after those test updates.
  • Native smoke: collapsed groups, opening only the middle group, active-group status, and visible failure state. German, Spanish and Korean catalogs and translation revisions are updated.
  • Partial verification: the full workspace just ci-test was not repeated; this Mac has the previously documented 65 store/external-agent failures outside this UI change. Nix is unavailable locally.

Opened from the turn's line, each step was still a full-width card,
and a tool call's command or path only showed once the card was open.

Each step is now one row on a rail under the line: an icon for what it
does, its title, and the command, path or query it acts on. An edit
shows the lines it added and removed. A running step is dim and inks
when it finishes, so the line is the only thing that moves; the
per-card spinner and the "completed" label went with the cards.
The "+n −n" on a step counted the lines kept for display, which stop
at a cap, so a 300-line write read "+199".

The counts now come from the call's whole input. A step that gains a
neighbour is measured again, since it loses the gap under it, and the
chip and counts are text a screen reader can reach.
@matthewrball
matthewrball marked this pull request as ready for review November 12, 2026 15:14
@marksftw

Copy link
Copy Markdown
Collaborator

I really like the direction this is headed. The log was getting noisy when showing all of the tool calls. However, I think this one has gone too far in the other direction. Could we have each "chunk" of activities with their own collapse/expanded state?

In these screenshots, it has multiple chunks of progress and I can either see all or none. It would be nice to individually expand/collapse activity for a chunk.

Screenshot 2026-11-15 at 9 47 32 PM Screenshot 2026-11-15 at 9 47 52 PM

Keep assistant explanations visible between independently disclosed activity chunks. Retain the turn-wide clock, native sheen, label morphing, entrance motion and disclosure springs.

Constraint: Preserve native motion and individual tool disclosure state.
Scope-risk: Chat grouping, disclosure, keyboard navigation and localization only.
Not-tested: Full workspace suite; this Mac has the previously documented Swift child-process failures.
matthewrball added a commit to matthewrball/Maple that referenced this pull request Nov 16, 2026
@matthewrball

matthewrball commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator Author

@marksftw updated in d2c18bf. Each group of tool/thinking steps between assistant messages now has its own expand/collapse control. Opening one leaves the others alone, explanations stay visible, and individual tool details keep their state.

The turn-wide toggle is gone; the line keeps one clock for the turn. Kept the existing sheen, label morphing, row entrances, disclosure fade, spring chevrons and reduced-motion behavior.

The first GIF shows the direction we went with. These are recordings of the interaction previews we compared; native screenshots of the implementation are in the PR description.

Independent activity groups expanding and collapsing

Two other approaches we considered Keeping the latest step visible while expanding earlier activity Separate activity groups with full-width expand and collapse headers

matthewrball added a commit to matthewrball/Maple that referenced this pull request Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants