Repository navigation
Agent: Show on a step that it waits for permission, and what you said - #1589
Open
matthewrball wants to merge 13 commits into
Open
matthewrball wants to merge 13 commits into
matthewrball wants to merge 13 commits into
Conversation
A call that needed permission looked like any running step, and once answered nothing in the transcript said whether it had been allowed. The step the request is about now reads "waiting" in coral, then "allowed" or "denied" for as long as the view shows the task. The card gains the tool's icon beside the call, a note field that says what it is for, and a line naming the mode that asked.
# Conflicts: # apps/maple-agent/app/src/ui/chat/turn.rs
Every call of a reply is on screen as running before the first is asked about, so the newest unfinished call was often the wrong one, and it kept the answer meant for another. The request names its tool and what the call would do. The step that waits is now the earliest unanswered call of the turn that matches both; with nothing to compare, no step is marked. What the user said is also text a screen reader can reach.
A call the mode lets through stays on screen as running beside an identical one that asks, so "the earliest match" could still be the wrong call. With more than one candidate the view now marks none and keeps no answer, rather than guess.
This was referenced Nov 12, 2026
matthewrball
marked this pull request as ready for review
November 12, 2026 15:14
Brings in master, independent activity chunks and the Korean catalog; adds the Korean permission strings.
A chunk counted its steps in four slots, but a step can also wait for permission or be refused. Size the counts by the states. Record the Korean permission strings.
Groups are folded by default, which hides the step that says it is waiting. The header read "running" under a line that said "Waiting for you".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The first row is a headless render with fixture rows. The second is a signed-in run of the whole stack (#1590) in a debug build.
Notes
chat-mode-autoandchat-mode-read-only.test_a_call_keeps_what_the_user_said_to_its_permission_request.just ci-lintandcargo test -p maple-agent-app --lockedpass on each of the four branches, andjust ci-extraat the top of the stack (Agent: List the files a turn changed under its reply #1590). Partial verification:just ci-testwas not run to the end here; on this Mac it fails 65 store and external-agent tests incrates/maple-agent, which this stack does not touch.