Skip to content

Agent: Show on a step that it waits for permission, and what you said - #1589

Open
matthewrball wants to merge 13 commits into
ux/turn-stepsfrom
ux/turn-permission
Open

matthewrball wants to merge 13 commits into
ux/turn-stepsfrom
ux/turn-permission

Conversation

@matthewrball

@matthewrball matthewrball commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

What this PR does

  • When Maple asks to run something, the step it is about reads "waiting" in coral, so you can see in the transcript which call the card is for.
  • After you answer, the step keeps what you said: "allowed" or "denied".
  • The permission card shows the tool's icon beside the command.
  • Its note field now reads "Or tell Maple what to do instead…".
  • Its footer says which mode asked: "Auto asks before actions like this", or the same for Read only.
  • The card's layout, buttons and keys are unchanged.

A step waiting for permission, light

A step waiting for permission, dark

Steps after the answers, light

Steps after the answers, dark

Live run: a step waiting for permission, light

Live run: a step waiting for permission, dark

The first row is a headless render with fixture rows. The second is a signed-in run of the whole stack (#1590) in a debug build.

Notes

  • A folded group says "waiting" in coral while one of its calls waits for permission. Groups are folded by default, and the header used to read "running" under a line that said "Waiting for you".
  • A group counts its steps across every step state. With four slots it crashed on a stopped or refused step.
  • Part 3 of 4, stacked on Agent: Draw a turn's steps as a thread #1588. Next: files changed (Agent: List the files a turn changed under its reply #1590).
  • The host sends the tool's name and action with the request, not the call's id. The step marked is the turn's one unanswered call with that tool and action. If two calls could be meant, no step is marked. A call id on the request would make this exact; say if you want it.
  • "allowed" and "denied" live in the view: they show for the answers given while the task is open, and are gone after a reload. A refused call still reads "failed" in history. Marking the row on the host would make it last; say if you want that.
  • Coral is on the waiting step only: the node, and the word "waiting".
  • New strings are in English, Spanish, German and Korean. The mode's name reuses chat-mode-auto and chat-mode-read-only.
  • Tests: test_a_call_keeps_what_the_user_said_to_its_permission_request.
  • Checked on macOS with Rust 1.98: just ci-lint and cargo test -p maple-agent-app --locked pass on each of the four branches, and just ci-extra at the top of the stack (Agent: List the files a turn changed under its reply #1590). Partial verification: just ci-test was not run to the end here; on this Mac it fails 65 store and external-agent tests in crates/maple-agent, which this stack does not touch.

A call that needed permission looked like any running step, and once
answered nothing in the transcript said whether it had been allowed.

The step the request is about now reads "waiting" in coral, then
"allowed" or "denied" for as long as the view shows the task. The card
gains the tool's icon beside the call, a note field that says what it
is for, and a line naming the mode that asked.
# Conflicts:
#	apps/maple-agent/app/src/ui/chat/turn.rs
Every call of a reply is on screen as running before the first is
asked about, so the newest unfinished call was often the wrong one,
and it kept the answer meant for another.

The request names its tool and what the call would do. The step that
waits is now the earliest unanswered call of the turn that matches
both; with nothing to compare, no step is marked. What the user said
is also text a screen reader can reach.
A call the mode lets through stays on screen as running beside an
identical one that asks, so "the earliest match" could still be the
wrong call. With more than one candidate the view now marks none and
keeps no answer, rather than guess.
@matthewrball
matthewrball marked this pull request as ready for review November 12, 2026 15:14
Brings in master, independent activity chunks and the Korean catalog; adds the Korean permission strings.
A chunk counted its steps in four slots, but a step can also wait for permission or be refused. Size the counts by the states. Record the Korean permission strings.
Groups are folded by default, which hides the step that says it is waiting. The header read "running" under a line that said "Waiting for you".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant