Repository navigation
Qt sidebar widgets: accept and forward a parent - #35
Merged
Merged
Conversation
SidebarToggle/SidebarPane/QtPlacementControl + the two QLabel chevrons in SidebarToggle were created without a parent. On Qt-for-Android each parentless QWidget becomes a top-level QWindow needing its own EGL surface. `SidebarToggleClassWindow` racing Android's accessibility bridge for the second EGL surface is what trips `QAndroidPlatformOpenGLWindow::eglSurface()`'s deadlock protector (SIGABRT) a second after ApplicationActive. Added `parent: QWidget | None = None` to the three __init__s, forward to super, and parent the chevron QLabels to self; SidebarPane also forwards parent=self when constructing its placement controls. Toad call sites (src/toad/qt/window.py) pass parent=self in a companion PR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SidebarToggle / SidebarPane / QtPlacementControl + the two QLabel chevrons in SidebarToggle were created without a parent. On Qt-for-Android each parentless QWidget becomes a top-level QWindow requiring its own EGL surface.
SidebarToggleClassWindowracing Android's accessibility bridge for the second EGL surface is what trips the deadlock protector (SIGABRT) one second after ApplicationActive.Added
parent: QWidget | None = Noneto the three__init__s (forwarded to super) and parented the chevron QLabels. SidebarPane also forwardsparent=selfwhen constructing its placement controls.Companion PR on toad passes
parent=selfat the four toad call sites.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn