Skip to content

Qt sidebar widgets: accept and forward a parent - #35

Merged
trissim merged 1 commit into
mainfrom
hotfix/qt-android-sidebar-parent
Nov 17, 2026
Merged

trissim merged 1 commit into
mainfrom
hotfix/qt-android-sidebar-parent

Conversation

@trissim

@trissim trissim commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

SidebarToggle / SidebarPane / QtPlacementControl + the two QLabel chevrons in SidebarToggle were created without a parent. On Qt-for-Android each parentless QWidget becomes a top-level QWindow requiring its own EGL surface. SidebarToggleClassWindow racing Android's accessibility bridge for the second EGL surface is what trips the deadlock protector (SIGABRT) one second after ApplicationActive.

Added parent: QWidget | None = None to the three __init__s (forwarded to super) and parented the chevron QLabels. SidebarPane also forwards parent=self when constructing its placement controls.

Companion PR on toad passes parent=self at the four toad call sites.

Test plan

  • AST parse
  • Toad APK rebuild + launcher tap — ApplicationActive persists, no SIGABRT

🤖 Generated with Claude Code

https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn

SidebarToggle/SidebarPane/QtPlacementControl + the two QLabel chevrons in SidebarToggle were created without a parent. On Qt-for-Android each parentless QWidget becomes a top-level QWindow needing its own EGL surface. `SidebarToggleClassWindow` racing Android's accessibility bridge for the second EGL surface is what trips `QAndroidPlatformOpenGLWindow::eglSurface()`'s deadlock protector (SIGABRT) a second after ApplicationActive.

Added `parent: QWidget | None = None` to the three __init__s, forward to super, and parent the chevron QLabels to self; SidebarPane also forwards parent=self when constructing its placement controls.

Toad call sites (src/toad/qt/window.py) pass parent=self in a companion PR.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gZLdupVQyBzHTmHBC9Cyn
@trissim
trissim merged commit bf09221 into main Nov 17, 2026
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant