Repository navigation
Run analysis: notify when a run ends - #155
Open
t0mdavid-m wants to merge 5 commits into
Open
t0mdavid-m wants to merge 5 commits into
t0mdavid-m wants to merge 5 commits into
Conversation
While a run is going, the Run page offers a 'Notify me when it ends' button that asks the browser for permission. When a run this session saw running ends, a hidden tab gets the outcome in front of its title until it is shown again, and a notification names the workflow and the outcome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepShSG5cNRTqoCXFo1
Brings the template's end-of-run notification (OpenMS/streamlit-template#569) and sets run_label so the notification reads 'OpenDDA analysis finished.' Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepShSG5cNRTqoCXFo1
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
…b is reported as failed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkEGepShSG5cNRTqoCXFo1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
What it does
An analysis of a large study runs for hours, and users work in other tabs meanwhile. Run analysis now tells them when it ends:
✓,✗or■in front until the tab is shown again;This brings the template change OpenMS/streamlit-template#569 (
src/workflow/run_notice.py,execution_section(name=...), the class attributerun_label).WorkflowTestsetsrun_label = "OpenDDA analysis", so the notification does not name the internal workflow slug. Merge #569 first. The next template sync then brings the same files.Screenshots
Run analysis while a run is going:
The run in these screenshots is simulated: a process ID file and a log were put in the workspace, and the progress panel shows an earlier run's steps. A browser check on that page did the following:
✓ OpenDDA.OpenDDAwhen the tab was shown.Tests
tests/test_run_notice.py(10 tests) andtests/test_run_flow.pypass.Generated by Claude Code