Skip to content

Add support for four Abyss timeless jewel node lines - #10412

Open
mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:feature/abyss-node-lines
Open

mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:feature/abyss-node-lines

Conversation

@mcagnion

@mcagnion mcagnion commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Four nodes added by the new Abyss timeless jewels in #10095 have a line that PoB did not parse, so it showed as "Not supported in PoB yet" and changed nothing:

  • Spiteful Allies: Minions Impale on Hit
  • The Loyal Few: Maximum number of raised Spectres, Skeletons and Zombies is 1
  • From Below: Cannot recover Mana
  • Sanguine Bargain: Attack Skills cost Life instead of Mana

Each line now uses the modifier of the closest wording PoB already supports:

  • minions have a N% chance to impale on hit with attacks, at 100%
  • maximum number of summoned raging spirits is N, applied to Spectres, Skeletons and Zombies
  • cannot gain mana
  • attacks cost life instead of mana

The four matching ModCache entries are updated. Like cannot gain mana, Cannot recover Mana stops Mana regeneration, leech and gain on hit or kill, but not Mana flasks.

Mana Recoup is not blocked by this line yet: the shared CannotGainMana flag does not stop it, which also affects the existing cannot gain mana. Left for a separate change.

Steps taken to verify a working solution:

  • Made one build per node with a real jewel whose seed conquers it, and opened each build on dev and on this branch:
    • Reclaimed Malevolence, seed 101, turns the Occultist notable Forbidden Power into From Below: Mana regeneration goes from 2.1 to 0.
    • Reclaimed Malevolence, seed 100, turns Forbidden Power into Sanguine Bargain: Double Strike with a sword costs 13 Life instead of 13 Mana.
    • Reclaimed Malevolence, seed 109, turns Forbidden Power into Spiteful Allies: the zombie gets 100% Impale chance and 69.5 Impale DPS.
    • Destructive Aspiration, seed 100, in jewel socket 7960, turns Mind Over Matter into The Loyal Few: Raise Zombie's Active Minion Limit goes from 6 to 1.
    • The other lines of these nodes stay "Not supported in PoB yet".
  • Added one calculation test per line: minion Impale chance 100%, Skeleton and Zombie limits 1 (and the Spectre limit override), Mana regeneration 0, and Double Strike with a sword costing Life instead of Mana. Each test fails without the change.
  • With the four lines as custom modifiers, Summon Skeletons' Active Minion Limit also goes from 7 to 1, and Raise Zombie, a spell, still costs 28 Mana.

Before screenshot:

From Below (Reclaimed Malevolence, seed 101):

before-from-below

Sanguine Bargain (Reclaimed Malevolence, seed 100):

before-sanguine-bargain

Spiteful Allies (Reclaimed Malevolence, seed 109):

before-spiteful-allies

The Loyal Few (Destructive Aspiration, seed 100):

before-the-loyal-few

After screenshot:

From Below:

after-from-below

Sanguine Bargain:

after-sanguine-bargain

Spiteful Allies:

after-spiteful-allies

The Loyal Few:

after-the-loyal-few

Spiteful Allies, The Loyal Few, From Below and Sanguine Bargain had
lines that the parser left unsupported:

- Minions Impale on Hit
- Maximum number of raised Spectres, Skeletons and Zombies is 1
- Cannot recover Mana
- Attack Skills cost Life instead of Mana

Map each to the modifier already used by the closest existing wording,
and update the four matching ModCache entries.
@mcagnion
mcagnion marked this pull request as draft November 7, 2026 23:22
@mcagnion
mcagnion marked this pull request as ready for review November 8, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant