Repository navigation
Conversation
Spiteful Allies, The Loyal Few, From Below and Sanguine Bargain had lines that the parser left unsupported: - Minions Impale on Hit - Maximum number of raised Spectres, Skeletons and Zombies is 1 - Cannot recover Mana - Attack Skills cost Life instead of Mana Map each to the modifier already used by the closest existing wording, and update the four matching ModCache entries.
mcagnion
marked this pull request as draft
November 7, 2026 23:22
mcagnion
marked this pull request as ready for review
November 8, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Four nodes added by the new Abyss timeless jewels in #10095 have a line that PoB did not parse, so it showed as "Not supported in PoB yet" and changed nothing:
Minions Impale on HitMaximum number of raised Spectres, Skeletons and Zombies is 1Cannot recover ManaAttack Skills cost Life instead of ManaEach line now uses the modifier of the closest wording PoB already supports:
minions have a N% chance to impale on hit with attacks, at 100%maximum number of summoned raging spirits is N, applied to Spectres, Skeletons and Zombiescannot gain manaattacks cost life instead of manaThe four matching ModCache entries are updated. Like
cannot gain mana,Cannot recover Manastops Mana regeneration, leech and gain on hit or kill, but not Mana flasks.Mana Recoup is not blocked by this line yet: the shared
CannotGainManaflag does not stop it, which also affects the existingcannot gain mana. Left for a separate change.Steps taken to verify a working solution:
Before screenshot:
From Below (Reclaimed Malevolence, seed 101):
Sanguine Bargain (Reclaimed Malevolence, seed 100):
Spiteful Allies (Reclaimed Malevolence, seed 109):
The Loyal Few (Destructive Aspiration, seed 100):
After screenshot:
From Below:
Sanguine Bargain:
Spiteful Allies:
The Loyal Few: