Repository navigation
Conversation
The release commit 490699b ("Set version to 1.18.2 for release") picked up the thrift-0.25.0/ directory that the prepare-RC workflow had built in the checkout, because prepare-rc.sh staged with `git add -A`. That put 3,550 Thrift files, compiled .o files included, into 1.18.2-rc0. Remove the tree so the branch matches 9ea3b78 again apart from the 1.18.2 POM versions. The workflow side is fixed on master in apache#3929. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The release commit 490699b ("Set version to 1.18.2 for release"), which is the current head of
parquet-1.18.x, did more than bump the 18 POM versions. It also committedthrift-0.25.0/: 3,550 files (about 332 MB unpacked), including 40 compiled x86-64.ofiles and the files Thrift'sconfiguregenerates. The prepare-RC workflow had built Thrift inside the checkout, andprepare-rc.shstaged the version bump withgit add -A. The tree ended up in the 1.18.2-rc0 source tarball (72.6 MB, against 1.4 MB for 1.18.1), so RC0 cannot be released.Re-running the workflow for RC1 without this change would tag the same tree again. The POMs are already at 1.18.2, so
prepare-rc.shskips the version bump and tags the branch head.What changes are included in this PR?
thrift-0.25.0/and nothing else (deletions only).After this PR, the branch tree matches 9ea3b78 (the commit before the release bump) except for the 1.18.2 POM versions:
The removed files stay in history through 490699b and the
apache-parquet-1.18.2-rc0tag, but they are no longer in the tree that RC1 will be built from.The workflow fix (build Thrift outside the checkout, stage with
git add -u, refuse to release from a dirty tree) is in #3929 againstmaster. #3929 should be merged before 1.18.2-rc1 is prepared. Otherwise the workflow builds Thrift in the checkout again, and the Nexussource-release.zip, whichmvn deploybuilds from the files on disk, would still include it.Are these changes tested?
git diff --stat 9ea3b783 HEADshows only the 18 POM version changes, as above..ofiles are left in the tree (git ls-files | grep '\.o$'is empty).Are there any user-facing changes?
No.
🤖 Generated with Claude Code