Repository navigation
chore: ask for just pre-push in PR template - #386
Open
vadim-anfv wants to merge 1 commit into
Open
vadim-anfv wants to merge 1 commit into
vadim-anfv wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 60.00% 59.51% -0.50%
==========================================
Files 25 25
Lines 4736 4552 -184
==========================================
- Hits 2842 2709 -133
+ Misses 1894 1843 -51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvpeter
approved these changes
Nov 12, 2026
3 tasks done
vadim-anfv
added a commit
that referenced
this pull request
Nov 14, 2026
eb9536d ci: make tracing optional, drop cli-table (Vadim Anufriev) 22a01a3 refactor(payjoin): return session history as JSON (Vadim Anufriev) Pull request description: ### Description The `--no-default-features` build and clippy jobs are red on every open PR, including Markdown-only ones (#386, #387). `cli-table`, `tracing` and `tracing-subscriber` are unused there, and recent cargo flags that ([`unused_dependencies`](https://doc.rust-lang.org/cargo/reference/lints.html#unused_dependencies), warn by default) while the workflow passes `build-warnings: deny`. `cli-table` is dropped entirely, as @tvpeter suggested: its last user, the payjoin session history, now returns JSON like the rest of the module. `payjoin history` on `master`: ``` +------------+-----------------+---------------------+-------------------------------+ | Session ID | Sender/Receiver | Completed At | Status | +------------+-----------------+---------------------+-------------------------------+ | 1 | Receiver | Not Completed | Waiting for original proposal | +------------+-----------------+---------------------+-------------------------------+ | 2 | Receiver | 2026-11-13 17:50:42 | Session cancelled | +------------+-----------------+---------------------+-------------------------------+ ``` and on this branch: ```json { "sessions": [ { "id": "1", "role": "Receiver", "status": "Waiting for original proposal", "completed_at": null }, { "id": "2", "role": "Receiver", "status": "Session cancelled", "completed_at": "2026-11-13 18:34:22" } ] } ``` ### Notes to the reviewers An active session now reports `"completed_at": null` instead of the string `Not Completed`. `tracing` is on `cbf` explicitly, although `cbf` already implies `_payjoin-dependencies`, so cbf logging does not depend on a payjoin-internal feature. `just pre-push` misses this: the lint is cargo's, not rustc's, so `-D warnings` after `--` does not apply. To reproduce: `cargo build --no-default-features --config 'build.warnings="deny"'`. The `SessionHistory` wrapper exists to keep the field order: serializing it directly preserves declaration order, while `json!` would sort the keys alphabetically. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: tvpeter: ACK eb9536d Tree-SHA512: 556923b5466720ea21dca4a7d4a5798e48cf2b317db0fbab68b3b94e20d6b822edab3d57c2a12e97f4b5c90e52ea727ba3770eb952da30423a26958d69a6e5d5
vadim-anfv
force-pushed
the
chore/pr-template
branch
from
November 14, 2026 06:03
dce8f4b to
5c91d42
Compare
Collaborator
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cargo fmtandcargo clippymiss the feature-gated failures that CI then reports.just pre-pushalso runs the tests and clippy with-D warningson both feature sets.Notes to the reviewers
That
cargoline in checks below comes from the current template, not the new one.And yes, I did run the commands.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing