Repository navigation
refactor: drop cli-table, payjoin history as JSON - #389
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 59.50% 59.33% -0.17%
==========================================
Files 25 25
Lines 4583 4562 -21
==========================================
- Hits 2727 2707 -20
+ Misses 1856 1855 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tvpeter
requested changes
Nov 13, 2026
tvpeter
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @vadim-anfv for checking the CI failures.
I think we should get ride of cli-table since the pretty flag was dropped.
vadim-anfv
force-pushed
the
ci/fix-opt-deps
branch
from
November 13, 2026 16:35
f4b97eb to
80ca38c
Compare
Collaborator
|
I just merged so you have conflicts. Also, update the PR title too. Thank you. |
The last cli-table user, dead weight since --pretty was dropped in bitcoindevkit#278.
Unused in a --no-default-features build, which recent cargo warns about and CI denies. cli-table has no users left at all.
vadim-anfv
force-pushed
the
ci/fix-opt-deps
branch
from
November 13, 2026 19:51
80ca38c to
eb9536d
Compare
Collaborator
Author
Rebased onto master, title updated, please have a look. |
tvpeter
approved these changes
Nov 13, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
--no-default-featuresbuild and clippy jobs are red on every open PR, including Markdown-only ones (#386, #387).cli-table,tracingandtracing-subscriberare unused there, and recent cargo flags that (unused_dependencies, warn by default) while the workflow passesbuild-warnings: deny.cli-tableis dropped entirely, as @tvpeter suggested: its last user, the payjoin session history, now returns JSON like the rest of the module.payjoin historyonmaster:and on this branch:
{ "sessions": [ { "id": "1", "role": "Receiver", "status": "Waiting for original proposal", "completed_at": null }, { "id": "2", "role": "Receiver", "status": "Session cancelled", "completed_at": "2026-11-13 18:34:22" } ] }Notes to the reviewers
An active session now reports
"completed_at": nullinstead of the stringNot Completed.tracingis oncbfexplicitly, althoughcbfalready implies_payjoin-dependencies, so cbf logging does not depend on a payjoin-internal feature.just pre-pushmisses this: the lint is cargo's, not rustc's, so-D warningsafter--does not apply. To reproduce:cargo build --no-default-features --config 'build.warnings="deny"'.The
SessionHistorywrapper exists to keep the field order: serializing it directly preserves declaration order, whilejson!would sort the keys alphabetically.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing