Repository navigation
Show XP breakdowns in cultivation log - #128
Open
putianyi889 wants to merge 2 commits into
Open
putianyi889 wants to merge 2 commits into
putianyi889 wants to merge 2 commits into
Conversation
Capture and persist raw XP components for live games and replay imports, then display them in a cap-aware hover chart. Add regression coverage for XP component totals. The changeset also includes plugin data and configuration files.
Owner
|
src/data/plugin_data这个目录不应该提交 |
ljzloser
reviewed
Nov 12, 2026
Collaborator
There was a problem hiding this comment.
审查了经验分项记录与悬浮图:当前实现中分项之和与本 PR 的经验公式一致;悬浮窗复用时也会重新设置数据并显示。
有一个需要与 #130 协调的合并风险:本 PR 保存未乘模式系数的 parts,并按 sum(parts) >= 100000 判断是否封顶;#130 则将最终经验改为 int(k * sum(parts))。例如 k=0.45、原始分项合计 120000 时,实际经验为 54000,但图表会提示已达上限;图中“合计取整后为最终道行”的说明也不再成立。现有分项测试样例本身超过上限,无法检出此问题。建议合并两个 PR 时统一分项显示和系数口径,并覆盖未封顶及封顶边界。
运行时数据目录已在现有讨论中指出,请一并处理。
本地补测:修仙插件测试 9 项通过;Qt 离屏检查了分项保存、重新加载和弹窗数据。与 #130 的分项口径问题仍是合并风险,本次未实际合并两个 PR。
Contributor
Author
需要加入gitignore吗? |
解决 scoped PySide6 枚举重构与道行 hover 饼图的合并冲突;移除误提交的插件运行时数据并补充 gitignore;分项改为按最终道行等比折算、封顶只看最终值,兼容 eee555#130 的模式系数口径;补充未封顶与封顶边界测试。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture and persist raw XP components for live games and replay imports, then display them in a cap-aware hover chart. Add regression coverage for XP component totals. The changeset also includes plugin data and configuration files.