Skip to content

Show XP breakdowns in cultivation log - #128

Open
putianyi889 wants to merge 2 commits into
eee555:masterfrom
putianyi889:XianNiu
Open

putianyi889 wants to merge 2 commits into
eee555:masterfrom
putianyi889:XianNiu

Conversation

@putianyi889

@putianyi889 putianyi889 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Capture and persist raw XP components for live games and replay imports, then display them in a cap-aware hover chart. Add regression coverage for XP component totals. The changeset also includes plugin data and configuration files.

49bd672818994137c7b26a47a7261280

Capture and persist raw XP components for live games and replay imports, then display them in a cap-aware hover chart. Add regression coverage for XP component totals. The changeset also includes plugin data and configuration files.
@eee555

eee555 commented Nov 11, 2026

Copy link
Copy Markdown
Owner

src/data/plugin_data这个目录不应该提交

@ljzloser ljzloser left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审查了经验分项记录与悬浮图:当前实现中分项之和与本 PR 的经验公式一致;悬浮窗复用时也会重新设置数据并显示。

有一个需要与 #130 协调的合并风险:本 PR 保存未乘模式系数的 parts,并按 sum(parts) >= 100000 判断是否封顶;#130 则将最终经验改为 int(k * sum(parts))。例如 k=0.45、原始分项合计 120000 时,实际经验为 54000,但图表会提示已达上限;图中“合计取整后为最终道行”的说明也不再成立。现有分项测试样例本身超过上限,无法检出此问题。建议合并两个 PR 时统一分项显示和系数口径,并覆盖未封顶及封顶边界。

运行时数据目录已在现有讨论中指出,请一并处理。


本地补测:修仙插件测试 9 项通过;Qt 离屏检查了分项保存、重新加载和弹窗数据。与 #130 的分项口径问题仍是合并风险,本次未实际合并两个 PR。

@putianyi889

Copy link
Copy Markdown
Contributor Author

src/data/plugin_data这个目录不应该提交

需要加入gitignore吗?

解决 scoped PySide6 枚举重构与道行 hover 饼图的合并冲突;移除误提交的插件运行时数据并补充 gitignore;分项改为按最终道行等比折算、封顶只看最终值,兼容 eee555#130 的模式系数口径;补充未封顶与封顶边界测试。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants