Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # core/src/components/button/test/basic/index.html
The ripple follows the theme instead of the mode, and ionic sets rippleEffect to match md. Button falls back to the mode until FW-7893 makes the base theme's config always apply.
There was a problem hiding this comment.
The @prop block is 230+ lines, so it lives in its own partial to keep button.scss starting with its rules. It also makes the docs easier to generate from the recipe later, since a script can rewrite the whole file without touching the stylesheet. Stencil reads @prop comments from the compiled CSS, so the docs output stays the same.
| export const ION_BUTTON_FILLS = ['solid', 'outline', 'clear'] as const; | ||
| export type IonButtonFill = (typeof ION_BUTTON_FILLS)[number]; | ||
|
|
||
| export const ION_BUTTON_SHAPES = ['crisp', 'soft', 'round', 'rectangular'] as const; |
There was a problem hiding this comment.
On next, soft changed its radius with the button's size. Now each shape has one radius per theme, and crisp covers the tighter corner that small buttons used to get, which also gives button the same shapes as badge.
# Conflicts: # core/src/components/button/button.tsx # core/src/utils/test/theme.spec.ts # core/src/utils/theme.ts
brandyscarney
left a comment
There was a problem hiding this comment.
This is looking really good! I found some minor issues.
Also, could the breaking list in the description be synced with BREAKING.md? BREAKING.md has 12 items and the description has 10.
| IonButton: { | ||
| fill: 'solid', | ||
| hue: 'bold', | ||
| shape: 'round', |
There was a problem hiding this comment.
Shouldn't the default shape for md buttons match the MD2 spec? MD2 contained, outlined and text buttons use the small shape, 4px, but md now defaults to round (999px), which comes from Material Design 3. #31636 syncs everything else to MD2, so a 36px button with a pill radius ends up matching neither spec. Should the default be soft? If the pill is intentional, could BREAKING item 1 say the radius stays MD3?
There was a problem hiding this comment.
The round default came from #29404, which landed on ionic-modular before this PR. The description lists it under "Not matched to the design on purpose", to avoid reversing a change that just landed. If the team would rather follow MD2's 4px, it fits better in #31636 with the rest of the MD2 sync. Thoughts?
There was a problem hiding this comment.
I'm fine with it going on #31636. I do think we should use the shape that matches MD2 since we are deciding to stick with that here first. In that PR I intentionally chose MD3 thinking we would be updating all of md eventually, but now that we might separate the themes and have md2 and md3 we should continue to use MD2 here.
There was a problem hiding this comment.
| [`${buttonType}-hue-${hueValue}`]: true, | ||
| [`${buttonType}-strong`]: strong, | ||
| 'in-datetime': this.inDatetime, | ||
| 'in-toolbar': hostContext('ion-toolbar', this.el), |
There was a problem hiding this comment.
Same for in-toolbar and in-toolbar-color: nothing in button.scss reads them now that toolbar styling is in tokens, but hostContext() still walks the DOM for them on every render. These did ship in 9.x, so apps may target them. Should they be removed and listed in BREAKING.md, or kept with a comment saying they're only for app CSS?
To reproduce:
git show origin/FW-6838:core/src/components/button/button.scss | grep -n "in-toolbar"It returns nothing.
There was a problem hiding this comment.
Removed in d046045, with BREAKING item 15 pointing to ion-toolbar ion-button and ion-toolbar[color] ion-button.
There was a problem hiding this comment.
Should we add in-datetime to breaking changes too?
There was a problem hiding this comment.
I don't think it needs one: in-datetime never shipped. It was added on next in #30770 (02-2026), and 9.x doesn't have it, so removing it doesn't break anything for users.
Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
# Conflicts: # core/scripts/testing/scripts.js
brandyscarney
left a comment
There was a problem hiding this comment.
Thanks for working through all of these! I left a few replies but LGTM!
Issue number: resolves #30625
What is the current behavior?
ion-buttonfragments its styles across per-theme stylesheets (.ios,.md,.ionic,.native).What is the new behavior?
ion-buttonto a single token-drivenbutton.scss, withIonButtonRecipe/IonButtonConfigand per-theme tokens::afteroverlayrippleEffectconfig is on instead of in md mode, and ionic sets it to match md. Until FW-7893, button falls back to the mode when no theme sets itmin.heighttoken, so a button can be made shorter than its default by lowering it along with the padding. Lowering only the padding can't shorten a button, which is what bug: controlling ion-button paddings fails below 12px #30625 ran into0.4, which matches its design's white washforegroundfor their label and the page background for their fill, matching the designsizeset on the spinner still appliesstartorendslot from the label with the icon's margins, unless a theme sets its ownIonToolbar.IonButtons.IonButton,IonDatetime.IonButton,IonInputPasswordToggle.IonButton). Toolbar tokens that depend on the toolbar's color sit underdefault(nocolor) andsemantic(with acolor)defaultsize in favor ofmediumSnapshots are in #31630.
Does this introduce a breaking change?
The button's CSS variables are replaced by token-driven custom properties. Use the global token for theme-wide styling, or the CSS variable for component-specific overrides.
iosbutton'sborder-radiusis6pxat every size, andmddefaults to999pxinstead of4px. To revert, setshape="soft"formd. Forios, setIonButton.shape.soft.border.radiusor--ion-button-shape-soft-border-radiusto14px. The token has no size, so scope the CSS variable by size for small (6px) and large (16px) buttons, such asion-button[size="small"].startandendslots ofion-input,ion-selectandion-textareafollow the button'sshapeinstead of always being circles. Forios, setshape="round"to keep them circular.iosclear buttons use the same font size as the other fills, instead of17pxat the default size. To keep it, set--ion-button-size-medium-font-sizeto17px.iosbutton is28px,34pxand50pxtall at the small, default and large sizes, with less padding. To revert, setIonButton.size.<size>.min.heightor--ion-button-size-<size>-min-heightto2.1em,3.1emand3.1em, and the padding to4px 0.9em,13px 1emand17px 1em.md, they're a few pixels smaller at the small and default sizes and larger at the large size.md, the focus and hover tint ofoutlineandclearbuttons in a toolbar'sion-buttonsuses--ion-text-color, so it no longer follows a custom toolbar color. To match one, setIonToolbar.default.IonButtons.IonButton.hue.bold.<fill>.focus.backgroundand.hover.background, or the matching CSS variables, using the color at0.12for focus and0.04for hover.md, buttons in anion-buttonsoutside a toolbar match standalone buttons instead of using the toolbar's colors. BREAKING.md has the CSS to keep the previous appearance.iosandmdspinners in thestartandendslots are spaced from the label like icons. To remove the space, setIonButton.size.<size>.spinner.leading.marginand.trailing.margin, or the matching--ion-button-size-<size>-spinner-*-margin-*variables, to0.<fill>withsolid,outlineorclear, and<shape>withcrisp,soft,roundorrectangular. Buttons with acolorread the same tokens undersemantic.--backgroundIonButton.hue.bold.<fill>.default.background--ion-button-hue-bold-<fill>-default-background--background-activatedIonButton.hue.bold.<fill>.activated.background--ion-button-hue-bold-<fill>-activated-background--background-focusedIonButton.hue.bold.<fill>.focus.background--ion-button-hue-bold-<fill>-focus-background--background-hoverIonButton.hue.bold.<fill>.hover.background--ion-button-hue-bold-<fill>-hover-background--border-colorIonButton.hue.bold.<fill>.default.border.color--ion-button-hue-bold-<fill>-default-border-color--border-radiusIonButton.shape.<shape>.border.radius--ion-button-shape-<shape>-border-radius--border-styleIonButton.hue.bold.<fill>.default.border.style--ion-button-hue-bold-<fill>-default-border-style--border-widthIonButton.hue.bold.<fill>.default.border.width--ion-button-hue-bold-<fill>-default-border-width--box-shadowIonButton.hue.bold.<fill>.default.box.shadow--ion-button-hue-bold-<fill>-default-box-shadow--colorIonButton.hue.bold.<fill>.default.color--ion-button-hue-bold-<fill>-default-color--color-activatedIonButton.hue.bold.<fill>.activated.color--ion-button-hue-bold-<fill>-activated-color--color-focusedIonButton.hue.bold.<fill>.focus.color--ion-button-hue-bold-<fill>-focus-color--color-hoverIonButton.hue.bold.<fill>.hover.color--ion-button-hue-bold-<fill>-hover-color--ripple-colorIonButton.hue.bold.<fill>.rippleEffect.color--ion-button-hue-bold-<fill>-ripple-effect-color--transitionIonButton.transition--ion-button-transition--background-activated-opacity,--background-focused-opacityand--background-hover-opacityare removed. A state's background replaces the button's instead of tinting it, so the opacity goes in the value: layer the tint over the base color with alinear-gradienton solid buttons, or usergba(var(--ion-color-primary-rgb), 0.12)on outline and clear.--opacityis removed: setopacityonion-button.--padding-*variables are no longer documented, but still work when set on the button itself. Replace<size>withsmall,mediumorlarge:--padding-topIonButton.size.<size>.padding.top--ion-button-size-<size>-padding-top--padding-endIonButton.size.<size>.padding.end--ion-button-size-<size>-padding-end--padding-bottomIonButton.size.<size>.padding.bottom--ion-button-size-<size>-padding-bottom--padding-startIonButton.size.<size>.padding.start--ion-button-size-<size>-padding-start.button-solid/.button-outline/.button-clear.button-fill-solid/.button-fill-outline/.button-fill-clear.button-small/.button-default/.button-large.button-size-small/.button-size-medium/.button-size-large.button-default(fill="default").button-fill-solid.button-round.button-shape-round.button-block/.button-full.button-expand-block/.button-expand-fulldefaultsize is deprecated. It logs a warning and renders asmedium.ion-button.mdorion-button.ios.roundbuttons no longer add26pxhorizontal padding (every size inios, the default size inmd). BREAKING.md has the CSS to revert.defaultfill is deprecated. It logs a warning and renders assolid, also insideion-buttons. Removefillthere to keepclear.ion-buttonno longer addsin-toolbarorin-toolbar-color. Useion-toolbar ion-buttonandion-toolbar[color] ion-buttoninstead.Other information
Why these choices
size.<size>.min.heighttoken sets both, so a square can't drift from the text buttons beside it. Notaspect-ratio: it needs Firefox 89, and Ionic supports Firefox 75. Equalmin-widthandmin-heightmake the same square in every supported browser.next, while text buttons were about 27, 50 and 62px. Sharing one height means picking one, and the kit's values match the icon-only buttons, so no iOS icon-only button changes size.::afteroverlay painted a state color at an opacity, which a theme couldn't set as one value. Each state's token is now the final color, rendering the same color asnext(md's focused solid is still white at 24% over primary). Wherenexttinted withcurrentColororshade, which have no-rgbvariable, the closest variable stands in, a few RGB levels off; a comment marks each one. Nocolor-mix(), since it needs Chrome 111, Safari 16.2 and Firefox 113: tints usergba()or the newoverlay()helper, which paints the same pixels.next. ios has no ripple, so its activated tokens tint the button. No rule depends on the ripple, so an app's override of the activated tokens applies in every theme.0.4because its design draws a 60% white wash over the whole button, and0.4paints the same colors on a white page. Before, ionic stacked the wash and a0.5fade, so disabled buttons were fainter than the design.unset, which is its initial value, so no theme needsborder: none,box-shadow: noneoropacity: 1entries.--padding-*still works on the button: the button readsvar(--padding-*, <token>)and resets the hooks on:host, so.ion-paddingon the button applies, but an ancestor's (likeion-content.ion-padding) doesn't leak in. That matchesion-contentand v9.sizeset on the spinner. The scale starts at the theme's default spinner size, and ios and md set none, so they fall back to the spinner's own size as in v9.IonToolbar: { IonButtons: { IonButton: { … } } }generates:where(ion-toolbar ion-buttons) ion-button { --ion-button-*: … }. The:where()keeps it at the specificity ofion-button, so an app's class on the button overrides it. Toolbar tokens that depend on its color go underdefaultandsemantic, which add:not(.ion-color)and.ion-colortoion-toolbar, so a button placed directly in a colored toolbar keeps its own colors, as onnext. Keys that don't depend on the color, like size and shape, stay in a shared block. That block can't set a key the direct-button blocks set, since the blocks are ordered by the specificity they'd have without:where()and the color class comes later; a spec fails if it does. Datetime and the password toggle render their buttons inside their own shadow root, where page CSS can't reach, so their hosts pass the tokens down by inheritance. A spec fails if a component renders a migrated child without that entry.17pxcame from the iOS 13 list header spec (feat(list-header): redesign list header for iOS spec #19915). The iOS 17 and 18 kits use the same font for plain and filled buttons.@propdocs in_button.docs.scss: keepsbutton.scssstarting with its rules. Stencil reads@propcomments from the compiled CSS, and the docs output (core.json,api.txt,html.html-data.json) lists the same variables as before.Not matched to the design on purpose
rounddefault from feat(button): set default shape to soft for ios and round for md and ionic themes #29404 instead of MD2's4px, to avoid reversing a change that just landedbasefor their border like every other color, so it's lighter than onnextLeft for the parents
Parent rules that set button variables the migration removes, such as
--colorand--background, moved to nested tokens, since they would stop working.--padding-*still works on the button, so the parents' padding rules stay until each parent migrates:ion-buttons, datetime, input, select, textarea, item and list header still set--padding-*on buttons; each moves it to a nested token in its own migrationion-buttonscaps buttons at 32px tall, so the iOS toolbar icon button is 38×32Known gaps
nextrule had no effect (--background-activated: transparent, overridden bybutton.ios.scss) and was ported as a live token; feat(button): sync the ios theme with iOS 17 #31645 removes itTODO(FW-7935)). It fails onnexttoo--ion-background-colorto white. In an app, it follows the pageHow to test
--ion-button-size-medium-min-height: 0and--ion-button-size-medium-padding-top/-bottom: 2pxon a button. It gets shorter (#30625)