Repository navigation
feat(button): add recipe and tokens #31628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
fd55153
feat(button): add recipe and tokens
thetaPC 7ea4a96
fix(button): keep datetime's ionic month buttons square
thetaPC c725df3
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC bf191d5
refactor(button): nest the min height and width tokens
thetaPC e2c3d40
fix(button): keep the default text color under the ripple
thetaPC dac0162
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 5a0d6ae
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 066c5e5
refactor(button): remove the line height token
thetaPC 8b74240
chore(button): point the padding hook TODOs at each parent's migration
thetaPC e9734ba
docs(button): explain the padding hook reset
thetaPC d377d88
feat(button): render the ripple from the rippleEffect config
thetaPC f475ea4
test(button): note the ripple depends on the rippleEffect config
thetaPC 4c8ed2c
test(button): loop over the interface arrays
thetaPC 3945d12
style(buttons, datetime): remove comments about where moved rules went
thetaPC 066e21b
fix(buttons): keep the toolbar color on back and menu buttons
thetaPC 6b56029
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 5b4bb10
test(button): remove duplicate blank line from the basic test page
thetaPC 787d037
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC ccf6294
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC abcef80
fix(button): skip colored toolbars for buttons placed directly in a t…
thetaPC 2d1eeb1
fix(datetime): tint the md month arrows with their own color
thetaPC 8e90b95
fix(button): let the activated tokens apply when the ripple renders
thetaPC 0845111
docs(breaking): show how to tint button states without the opacity va…
thetaPC e864a6d
docs(breaking): scope the ios button radius override by size
thetaPC ab930d6
docs(themes): say the ios toolbar outline and clear tints stay primary
thetaPC 7d858d9
docs(theme): shorten the INTERNAL_CHILD_COMPONENTS docs
thetaPC 22e4f6e
test(button): cover the default size warning and a shorter button
thetaPC 78c89e3
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 05c07e8
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 8f9fabc
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC b9d6022
test(toolbar): check that a button placed directly in a colored toolb…
thetaPC 50a24f7
docs(button): scope the ios radius revert by size class
thetaPC 2af22bb
docs(button): match the md toolbar tint comment to ios
thetaPC aa8f5c1
docs(button): label the toolbar default groups
thetaPC 392620e
refactor(button): keep the md and ionic pressed feedback under ripple…
thetaPC 7fa69a3
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 8989e98
docs(button): list the md toolbar tint and ion-buttons color changes
thetaPC d190c88
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC c58c6d3
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC c62fd3d
Merge branch 'FW-6838-tests' into FW-6838
thetaPC 18ad907
fix(button): keep the toolbar color on focus and hover
thetaPC c37e819
docs(breaking): cover every button fill and state in the ion-buttons …
thetaPC fc4a017
fix(button): keep the toolbar color on ionic hover
thetaPC 59288e4
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC 2322ed4
test(theme): restore the shadow root checks reverted in a merge
thetaPC f5b5b11
fix(button): keep the resting background when disabled
thetaPC 19b4637
refactor(button): use dynamicFontMax for the ios font sizes
thetaPC 54195be
refactor(button): build the clamped sizes with the theme helpers
thetaPC f58afed
refactor(button): destructure rippleType and inButtons in render
thetaPC 3d4b6b4
refactor(button): remove the unused in-datetime class
thetaPC 1c22bb7
docs(breaking): remove button shape classes that 9.x never had
thetaPC c972695
docs(breaking): list the removed round button padding
thetaPC e75d97c
fix(button): render the deprecated default fill as solid
thetaPC d046045
refactor(button): remove the in-toolbar and in-toolbar-color classes
thetaPC 53e7268
fix(theme): let class overrides beat a parent's nested tokens
thetaPC f01725f
docs(breaking): call the button mode classes mode classes
thetaPC a7d15eb
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC be04eb9
fix(button): keep the ionic password toggle at its 40px size
thetaPC fbc6cc8
fix(button): space ios and md spinners from the label like icons
thetaPC 96a3692
Merge remote-tracking branch 'origin/FW-6838-tests' into FW-6838
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.