Repository navigation
Conversation
…n ones Refs #3091 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
mctest/mxtest --comp=Xnow also selects instruments using components thatINHERITfromX(followed transitively). Closes the CI gap described in #3091: #3088 changedFluorescence, but theFluoPowderusersSOLEIL_CRISTALandSOLEIL_MARSwere never tested.The CI workflows already pass
--comp=<changed comps>, so they need no change, and McStas and McXtrace are covered by the same code. The widened list is shown in the existing "Instrument list includes those using component(s) ..." log line.Examples of the widening (selection block run against the component trees of this branch):
--compFluorescence(McXtrace)FluoCrystal,FluoPowder,Fluo_detector,FluorescenceSOLEIL_CRISTALandSOLEIL_MARSSlit(McXtrace)Diaphragm,SlitMonitor_nD(McStas)Monitor_Sqw,Monitor_nD,StatisticalChopper_Monitor,Union_abs_logger_nD,Union_abs_logger_nD_scintillatorSingle_crystal(McStas)Unittest_IO_parent(McStas)Unittest_IO_cancel,Unittest_IO_extend,Unittest_IO_keep,Unittest_IO_noinit,Unittest_IO_parentUnittest_INHERIT_OVERRIDE)Side effects:
Over-matching
The search is a plain text match of
INHERIT <word>over the whole.compfile. It does not parse the component, so it also matches in comments and in the doc header. A component that only mentionsINHERIT Xin text is treated as derived fromX, and its users get tested whenXchanges.mainthere are 64 matches in 25 component files, 5 of them in comments or doc headers. None of the 5 produces a false derivation today:NMO.comp,MCPL_input_once.comp,Unittest_IO_extend.comp(S and X): prose such as "uses INHERIT of all sections", where the matched word (of,within) is not a component name.FluoPowder.comp: the comment "we can't INHERIT Fluorescence ..." matches, but the component doesSHARE INHERIT Fluorescenceanyway.INHERITwould cause a false derivation. Accepted to keep this at a few lines instead of a parser.Declaration of use of AI-tools
Development OS / boundary conditions
Developed on macOS. The new selection block was run against the
mcstas-compsandmcxtrace-compstrees of this branch to list the selected instruments (table above). A fullmctest/mxtestrun with--compwas not done, and nothing was tested on Linux or Windows; the code is plain Python (re,pathlib).PR Checklist for contributing to McStas/McXtrace
My PR is meant to fix a specific, existing issue
My contribution contains something else
🤖 Generated with Claude Code