Repository navigation
fix: integrate Tao macOS lifecycle and borderless shadow fixes - #92
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the pinned Tao fork to
73ab3e94986f045ad379faee9b2560bffd84012c(webviewjs/tao#3) and exercise both reported macOS behaviors through the locally built N-API addon and public TypeScript API. Public API remains unchanged; the lockfile changes only the Tao and Tao macro Git sources.Tao changes
The fork merges upstream dev through
2f60c2d5, preserving external pumping and fork dragging behavior. Upstream changes include macOS typed Objective-C class migrations, redraw reentrancy protection and borderless maximizable state, Linux theme notifications/system theme tracking, and Windows monitor selection for logical positions. No WebviewJS API adaptation was required by the merge.841ed17bd02911dfd74b4668acf628d3d3245c74: scope CF run-loop observers to EventLoop lifetime, avoiding stale callbacks/panics when an embedding host continues running after Tao destruction.002db4a9dca92d56b205e29a093f488d5ca85f06: explicitly apply both shadow values to NSWindow. Borderless windows with resizable/minimizable disabled default to no shadow in AppKit. WebviewJS already forwards macosHasShadow directly and does not override the setting, so the fix belongs in Tao.Native reproductions
Related: github/copilot-cli#5398 and #91.
Added opt-in macOS integration tests, separate from the fake-binding runtime suite. A Bun parent serves localhost HTTP while fresh Node and Bun children own AppKit on their main thread. A watchdog kills a stuck child; finally blocks reap children, close the server, dispose windows/webviews and stop pumping. CI now builds and runs these native regressions on macos-latest.
dist/index.jswithwhenReady({interval:50,ref:false}). Verify localhost, inline HTML and data URL DOM loading before another window or explicit focus intervention, JS evaluation/mutation, page timers, HTTP fetches, IPC, seven seconds without input, repeated manual event pumping, multiple windows, resizing, focus and cleanup.9bb2bdcaddon fails the reported all-false-style/true-shadow combination under both Node and Bun; the updated addon passes.Validation
Host: macOS 27.0.1 (26A434), ARM64, Node 24.22.1, Bun 1.4.4, Rust 1.99.1.
Passed locally:
bun run test: 108 passed, 1 existing skip, including strict public API/example type fixtures.bun run check, strict typecheck of the new test runner,bun run clippywith warnings denied.cargo test --manifest-path packages/webview/Cargo.toml --lib: 21 passed.bun run lint(one existing create-webview control-regex warning),bun run format:check,git diff --check.cargo checkfor aarch64-apple-darwin, x86_64-apple-darwin and x86_64-pc-windows-msvc. Cross-checks are compilation checks, not linked executables or runtime validation.Limits and remaining findings: