Repository navigation
feat(view3d): main view on the PuzlWerk viewer behind a flag (A1) - #78
Conversation
Flag parsing (`?viewer=puzlwerk`), the state shown by the static view and the color frame as hex colors, without importing the viewer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cubeDisplayCard selects the view through MainCubeView: with `?viewer=puzlwerk` a static PuzlWerk view of the current state (sizes 2-15) with the axis gizmo colored from the color frame, otherwise the existing view. The viewer is a dynamic import. Adds an e2e spec for sizes 2, 3, 7 and 15. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review: FINDINGS head=14929c19ecc962526c072b5334f903adfc88be8f patch-id=9c1de09039b7e5a3c14238eed2c9744ca68f8e42 pr=78 |
…the flag once The card imports the pure flag module statically and keeps the direct lazy import of cubeView3D; the PuzlWerk view is a separate lazy import. The dialog choice uses mainViewerKind as its only flag parser. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…hange data-indicator now reports the colors given to the stage. The e2e asserts the exact X, Y, Z colors of a solved cube and the new colors after a state with other centers, on the same canvas. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review: CLEAR head=ed0412b6cc56fdcbb31220b3b64fa2ceaa4c7991 patch-id=84728d040008d2514f97b47d9a07e125372a45cb pr=78 |
Cross-project architecture gate — 2026-11-19 (documentation only)This A1 main-view change is the base of the currently open, non-Draft stack #78 → #79 → #80. Its feature flag keeps the existing view as default, but A2 adds layer play and A3 adds toolbar/interactions; the stack is a main-view integration, not merely the previously authorized read-only inventory or Draft capture-review comparison. The 2026-11-17 owner decision authorized a Draft M2 migration spike, with separate owner merge/switch-over acceptance and no waiver of the binding Cubistry #21 2×2 Counter M1 acceptance. All five M1 DoD boxes remain unchecked. The 2026-11-18 merge of comparison spike #64 does not by itself authorize the broader A1–A3 main-view merge or make the temporary Before Ready/merge of this stack: record a specific owner decision either accepting complete M1 and separately approving M2, or expressly permitting this bounded, default-off early integration; document owner visual/behavioral acceptance, regression and license/distribution gates. Technical review CLEAR / green CI are not this approval. Final target remains direct No implementation, merge, branch or Rust changes were made by this architecture check. |
Package A1 of the main-view migration: the main 3D view (view mode) can show the PuzlWerk viewer behind
?viewer=puzlwerk; the default stays the existing view. Refs #29,docs/viewer-migration-inventory.md(G1, G10 for this view).Changes
cubeDisplayCard.tsximports the pure flag module statically, keeps the direct lazy import ofcubeView3Dand loadspuzlwerkCubeViewas a separate lazy import (only with the flag). The default path has no intermediate chunk (review round 1: waterfall fixed).puzlwerkMainView.ts:mainViewerKind(the only flag parser; the dialog choice uses it), shown state (initialCube ?? cube), color frame as hex (U R F D L B).indicatorColorsFromFrame; a frame change recolors it without rebuilding the stage;data-indicatorreports the colors given to the stage.Tests
puzlwerkMainView.test.ts,cubeView3DChoice.test.ts: 5 pass; cases?other=puzlwerk,?puzlwerk. Mutations: shown state, frame order,!== 'classic',search.includes('puzlwerk'): each fails.main-view-flag.spec.ts: 6 pass (sizes 2, 3, 7, 15 with exact gizmo colors#cf2a3a,#f7f6f1,#1e9e57; recolor on a state with other centers, same canvas; default without viewer request). Mutations: card back toCubeView3D, flag always on, frame not passed, X/Y swap (5 fail),colorKeydropped from the effect deps (1 fails).git diff --check: 0 findings. e2eviewer-spike,cubeView3D-view: pass locally, 24 of 24 withmain-view-flag.cubeView3D-view.spec.ts:10, 28 runs each, load 5 to 8: base 5 failed, head 8 failed (earlier head run 7; same assertion). Cause not established.npm run build), base to head:index394.32 to 394.96 kB (gzip 136.30 to 136.55),cubeView3D48.47 to 48.43 kB,cubeView3DChoice0.89 to 0.86 kB (dialogs only),puzlwerkCubeView769.61 to 770.24 kB (flag only).indexreferencescubeView3Ddirectly with the same two preloads as base.Not verified: real GPU; look acceptance by the owner.
Blocker: none.
No session links.
🤖 Generated with Claude Code