Repository navigation
Conversation
|
Review: CLEAR head=b8cd2151c47227a356782d49dab374d386379c03 patch-id=6c70fd388331950e1bcd5d45731aa14592f70656 pr=79 |
The viewer draws no overlay texts. The wording and conditions of the help line, the wide-turn badge and the locked hint follow the existing view; the wide badge reads the viewer's play events. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A pure name for the viewer's turn events (selection or end), used as a state signal on the stage host so tests can wait on the turn instead of a timer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The viewer draws no texts. The main view (flag only) shows the help line, the wide-turn badge and the locked hint as DOM over the stage, with the wording and conditions of the existing view. The wide badge follows the viewer's play events; the locked hint follows a drag on the stage while the layers are locked (view mode). With layer moves on, the stage plays layers with the move policy any; the dialogs stay view only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The start-distance check used toHaveCount(0), which waits for the hint to expire and so passes after a wrongly early hint. A one-shot count after two frames fails on it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
90d37a2 to
75e8a1a
Compare
Package A2 of the main-view migration (stacked on A1): behind
?viewer=puzlwerkthe main 3D view shows the help line, the wide-turn badge and the locked hint as DOM over the PuzlWerk stage, with the wording and conditions of the existing view. The default view is unchanged. Refs #29,docs/viewer-migration-inventory.md(G4, G7, G9).Changes
puzlwerkHints.ts(pure): help text (pointer kind, seam rule), wide badge fromturn-begin/turn-end(a drag over 1 < layers < size), lock-hint rule (start distance, 5 s gap vialockedHintDue),turnSignal.usePuzlwerkHints.ts: reusesuseCubeHelpHint; capture handlers on the stage wrapper;onPlayEventfeeds the badge.puzlwerkPlay.ts: with themainprop the stage plays layers (move policyany, standard layer widths; view mode while locked, play mode with the layer-moves cookie). One player and child per shown state; turns are not held in app state (later package).puzlwerkCubeView.tsx: wrapper around the host for the overlays; the dialogs stay view only. Test signalsdata-interaction,data-turn.Gaps and deviations
turn-begin, so there is no badge on the Shift press; a Shift drag on a 2x2 turns one layer and shows no badge (existing view: badge on Shift press at any size).Tests
puzlwerkHints.test.ts: 9 pass; 5 mutations fail. e2emain-view-hints.spec.ts: 5 pass; 10 mutations fail. Withmain-view-flagandviewer-spike: 18 pass.e2e/main-view-hints.spec.ts:146) is vacuous;toHaveCount(0)waits out the 2.5 s hint, so its mutation survives. The unit test coverslocked: false.git diff --check: 0 findings.index394.93 to 392.04 kB,cubeView3D48.43 to 47.47,puzlwerkCubeView770.24 to 780.13 (flag only); default-path shared chunks: one more file, +0.5 kB, all preloaded withcubeView3D.Stack: restacks 0, heavy runs 0. Merge only with the whole stack, in order feat(view3d): main view on the PuzlWerk viewer behind a flag (A1) #78, feat(view3d): overlay hints and layer play on the PuzlWerk main view (A2) #79, feat(view3d): view toolbar, toggles and shortcuts on the PuzlWerk main view (A3) #80.
Blocker: none. Merge order: #78, then this PR, then #80.
No session links.
🤖 Generated with Claude Code