Skip to content

feat(view3d): view toolbar, toggles and shortcuts on the PuzlWerk main view (A3) - #80

Merged
wstein merged 2 commits into
feat/main-view-a2-hintsfrom
feat/main-view-a3-bars
Nov 19, 2026
Merged

wstein merged 2 commits into
feat/main-view-a2-hintsfrom
feat/main-view-a3-bars

Conversation

@wstein

@wstein wstein commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

Package A3 of the main-view migration (stacked on A2, #79): behind ?viewer=puzlwerk the main 3D view gets FACES, Stickerless, Auto-rotate, Move layers and the keyboard shortcuts, driving the viewer's setters. The default view is unchanged. Refs #29, docs/viewer-migration-inventory.md (G5, G6, G8, G9).

Changes

  • puzlwerkBars.ts (pure): FACES list, face-letter keys, arrow-key steps (0.2 rad, pole limit), toggle labels of the existing toolbar.
  • puzlwerkToolbar.tsx: markup and classes of the existing toolbar.
  • puzlwerkCubeView.tsx: setViewPreset, setDisplayOrientation, setAppearance (default on, cookie), setAutoRotate (cookie), lock via interaction mode (cookie).
  • puzlwerkPlay.ts: the lock keeps the shown state; seamWide reaches the play target; applyConstruction retries on Busy.

Gaps

  • setAppearance answers Busy while a state loads; the app retries per frame. Presets leave the zoom unchanged (the existing Isometric also resets it). No idle signal (G9).
  • Not here (need app state): CUBE group, move history, sound toggle.

Tests

Blocker: none. Merge order: #78, #79, then this PR.

No session links.

🤖 Generated with Claude Code

wstein and others added 2 commits November 19, 2026 04:48
FACES button list, face-letter and arrow-key shortcuts, toggle labels
and the pitch/yaw reading of a display orientation, with the labels,
steps and limits of the existing toolbar. A test ties the viewer's
presets to the existing view's angles.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n view

Behind the flag the main view gets the FACES presets, the Stickerless,
Auto-rotate and Move layers toggles and the face-letter and arrow-key
shortcuts of the existing toolbar, driving the stage through
setViewPreset, setDisplayOrientation, setAppearance, setAutoRotate and
the interaction mode. The lock switches play and view mode without
rebuilding the shown state; the seam setting reaches the play target. The
CUBE group, the move history and the sound toggle need app state and are
not part of this change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=4e61ef525e2eda93d56e4c8e7d4bc99a31f9e765 patch-id=318e50ba82cf176a9c9368bccc431b43fa7d8b46 pr=80
Round 1, strong tier, delta feat/main-view-a2-hints (b8cd215)...4e61ef5, no merges. Mergeable only after #79 and #78 (stacked, bottom-up).
1 low nit puzlwerkCubeView.tsx:77,233,246,74,239: cookie persistence partly untested; dropping the auto-rotate write or read, the layer-moves write, or renaming the stickerless cookie survives all e2e. Behavior is right (own probe: cookies 0/1 after toggles, auto-rotate on from cookie).
2 low nit puzlwerkCubeView.tsx:299: a preset no longer pausing auto-rotate (interact() removed) survives; the existing view pauses on presets and keys.
3 low nit puzlwerkPlay.ts:94,104: onShown sync and per-state player.dispose() untested (both removals survive; #79 item 3 carried). Own probe: 20 lock/stickerless/preset rounds, 1 canvas, 1 WebGL context, state kept.
4 low nit puzlwerkToolbar.tsx:63: lock button active class untested (removal survives).
5 low nit PR text: zoom gap is app-side, CubeStage.setZoom exists for an Isometric/Iso-back reset; vitest counts differ from mine (head 2076/47, base 2069/47; delta +7 matches).
Parity: 8 presets equal facePreset/isometricAngles (independent unit oracle), letters either case, arrows 0.2 rad with pole limit, keys only on the focused stage (not in the Cube select); modifiers ignored as in the existing view. Busy retry ends on dispose; addCube-vs-appearance race not reproducible (setAppearance 13-42 ms without yielding; 0 alerts in 111 tries).
Default path: index, cubeView3D, cubeView3DChoice chunks identical to base after hash normalization; modulepreloads unchanged (3); only puzlwerkCubeView 780.13 -> 783.91 kB.
Checks: typecheck, lint, format:check, typos, build, git diff --check: 0 findings. vitest head 2076 pass/47 fail, base 2069/47, same 47 (LFS); unit 7/7.
e2e x3: main-view-bars+hints 42/42, main-view-flag+viewer-spike+cubeView3D-view 72/72.
Mutations: unit 9 (5 author, 4 own), all killed; e2e 13 author all killed, 10 own (2 killed, 8 survive: items 1-4); 1 equivalent dropped.
CI at head: CI success (run 44462862233, attempt 1). Commits feat, Co-Authored-By, author = committer = git config, no session links. PR text 25 lines, one Blocker line.
Not checked: real GPU, touch/coarse pointer, look acceptance (owner), 7x7 wide badge.

@wstein
wstein marked this pull request as ready for review November 19, 2026 06:21

wstein commented Nov 19, 2026

Copy link
Copy Markdown
Owner Author

Architecture/merge gate inherited from A1 — 2026-11-19

This A3 PR is the non-Draft stack tip, stacked on #79 and #78. “Blocker: none” in the description refers to local implementation/review findings; it does not clear the project-level M1/M2 gate. See the specific architecture note on stack root #78, CubeAssembler #29, and binding Cubistry #21.

The owner allowed a Draft comparison/migration spike, not an automatic main-view rollout or permanent old/new flag. Until explicit owner scope/merge acceptance is documented, keep this stack reviewable but do not infer merge approval from technical CLEAR, CI or the merged capture-preview spike #64. Existing view and tests remain intact. Documentation only; no implementation/merge.

@wstein
wstein merged commit 0b301e5 into feat/main-view-a2-hints Nov 19, 2026
2 checks passed
@wstein
wstein deleted the feat/main-view-a3-bars branch November 19, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant